Index: lib/Sema/SemaExprCXX.cpp =================================================================== --- lib/Sema/SemaExprCXX.cpp +++ lib/Sema/SemaExprCXX.cpp @@ -7755,6 +7755,10 @@ TypoCorrection TC = SemaRef.getTypoExprState(TE).Consumer->peekNextCorrection(); TypoCorrection Next; do { + // Fetch the next correction by erasing the typo from the cache and calling + // `TryTransform` which will iterate through corrections in + // `TransformTypoExpr`. + TransformCache.erase(TE); ExprResult AmbigRes = CheckForRecursiveTypos(TryTransform(E), IsAmbiguous); if (!AmbigRes.isInvalid() || IsAmbiguous) { Index: test/Sema/typo-correction-ambiguity.cpp =================================================================== --- /dev/null +++ test/Sema/typo-correction-ambiguity.cpp @@ -0,0 +1,29 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +// Check the following typo correction behavior in namespaces: +// - no typos are diagnosed when an expression has ambiguous (multiple) corrections +// - proper iteration through multiple potentially ambiguous corrections + +namespace AmbiguousCorrection +{ + void method_Bar(); + void method_Foo(); + void method_Zoo(); +}; + +void testAmbiguousNoSuggestions() +{ + AmbiguousCorrection::method_Ace(); // expected-error {{no member named 'method_Ace' in namespace 'AmbiguousCorrection'}} +} + +namespace MultipleCorrectionsButNotAmbiguous +{ + int PrefixType_Name(int value); // expected-note {{'PrefixType_Name' declared here}} + int PrefixType_MIN(); + int PrefixType_MAX(); +}; + +int testMultipleCorrectionsButNotAmbiguous() { + int val = MultipleCorrectionsButNotAmbiguous::PrefixType_Enum(0); // expected-error {{no member named 'PrefixType_Enum' in namespace 'MultipleCorrectionsButNotAmbiguous'; did you mean 'PrefixType_Name'?}} + return val; +}