Page MenuHomePhabricator

Removed some questionable default arguments from setters
ClosedPublic

Authored by gribozavr on Sep 12 2019, 4:29 AM.

Details

Summary

They can be confusing -- what does it mean to call a setter without a
value? Also, some setters, like setPrintTemplateTree had false as
the default value!

The callers are largely not using these default arguments anyway.

Diff Detail

Repository
rL LLVM

Event Timeline

gribozavr created this revision.Sep 12 2019, 4:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2019, 4:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hokein accepted this revision.Sep 12 2019, 5:08 AM
This revision is now accepted and ready to land.Sep 12 2019, 5:08 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2019, 5:17 AM