Page MenuHomePhabricator

[clang-scan-deps] Add even proper-er dependency targets
ClosedPublic

Authored by jkorous on Sep 11 2019, 5:25 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jkorous created this revision.Sep 11 2019, 5:25 PM
arphaman accepted this revision.Sep 11 2019, 5:33 PM

LGTM with one suggestion

clang/tools/clang-scan-deps/ClangScanDeps.cpp
210 ↗(On Diff #219837)

Please use bool flags for LastMT/MQ/MD (HasMT?) as you don't need their values.

This revision is now accepted and ready to land.Sep 11 2019, 5:33 PM
jkorous marked an inline comment as done.Sep 11 2019, 5:37 PM
jkorous added inline comments.
clang/tools/clang-scan-deps/ClangScanDeps.cpp
210 ↗(On Diff #219837)

My bad. Absolutely!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2019, 5:48 PM