Page MenuHomePhabricator

[libcxx] Annotate unique_lock and shared_lock with thread annotations
Needs ReviewPublic

Authored by phosek on Sep 11 2019, 2:13 PM.


Group Reviewers
Restricted Project

Diff Detail

rCXX libc++

Event Timeline

phosek created this revision.Sep 11 2019, 2:13 PM

When are those annotations enabled? By default they're turned off, would it make sense to turn them on by default? It seems like we're missing out on something interesting here.

ldionne accepted this revision.Sep 11 2019, 2:19 PM

But I don't have any objection with the patch itself.

This revision is now accepted and ready to land.Sep 11 2019, 2:19 PM

It would be nice to have a test (in test/libcxx) to check that these annotations are in the expected places.

ldionne added a reviewer: Restricted Project.Nov 2 2020, 3:02 PM

Ping @phosek . Are we doing this?

This revision now requires review to proceed.Nov 2 2020, 3:02 PM