Page MenuHomePhabricator

[GlobalISel][AArch64] Check caller for swifterror params in tailcall eligibility
ClosedPublic

Authored by paquette on Sep 11 2019, 1:50 PM.

Details

Summary

Before, we only checked the callee for swifterror. However, we should also be checking the caller to see if it has a swifterror parameter.

Since we don't currently handle outgoing arguments, this didn't show up in the swifterror.ll testcase. (It did show up when I started implementing outgoing arguments though.)

Also, remove the swifterror checks from call-translator-tail-call.ll, since they are covered by the existing swifterror testing. Better to have it all in one place.

Diff Detail

Repository
rL LLVM

Event Timeline

paquette created this revision.Sep 11 2019, 1:50 PM
aemerson accepted this revision.Sep 11 2019, 4:17 PM

LGTM.

llvm/lib/Target/AArch64/AArch64CallLowering.cpp
500 ↗(On Diff #219791)

extra newline.

This revision is now accepted and ready to land.Sep 11 2019, 4:17 PM
This revision was automatically updated to reflect the committed changes.