diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -2652,6 +2652,15 @@ --E; continue; } + } else if (isa(NewAttribute) && + cast(New)->isInline() && + !cast(New)->isInlineSpecified()) { + // Don't warn about applying selectany to implicitly inline variables. + // Older compilers and language modes would require the use of selectany + // to make such variables inline, and it would have no effect if we + // honored it. + ++I; + continue; } S.Diag(NewAttribute->getLocation(), diff --git a/clang/test/SemaCXX/declspec-selectany.cpp b/clang/test/SemaCXX/declspec-selectany.cpp new file mode 100644 --- /dev/null +++ b/clang/test/SemaCXX/declspec-selectany.cpp @@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -std=c++14 %s -triple x86_64-windows-msvc -fdeclspec -verify +// RUN: %clang_cc1 -std=c++17 %s -triple x86_64-windows-msvc -fdeclspec -verify +// RUN: %clang_cc1 -std=c++14 %s -triple x86_64-scei-ps4 -fdeclspec -verify + +// MSVC emits this error too. +const int __declspec(selectany) test1 = 0; // expected-error {{'selectany' can only be applied to data items with external linkage}} + +extern const int test2; +const int test2 = 42; // expected-note {{previous definition is here}} +extern __declspec(selectany) const int test2; // expected-warning {{attribute declaration must precede definition}} + +extern const int test3; +const int __declspec(selectany) test3 = 42; // Standard usage. + +struct Test4 { + static constexpr int sdm = 0; +}; +__declspec(selectany) constexpr int Test4::sdm; // no warning