Page MenuHomePhabricator

[Mips][Disassembler] Disassembler checking N64 feature instead of GP64
ClosedPublic

Authored by vmedic on Dec 15 2014, 9:20 AM.

Details

Reviewers
dsanders
Summary

The single check for N64 inside MipsDisassemblerBase's subclasses is actually wrong. It should be testing for FeatureGP64bit.

Diff Detail

Event Timeline

vmedic updated this revision to Diff 17289.Dec 15 2014, 9:20 AM
vmedic retitled this revision from to [Mips][Disassembler] Disassembler checking N64 feature instead of GP64.
vmedic updated this object.
vmedic edited the test plan for this revision. (Show Details)
vmedic added a reviewer: dsanders.
vmedic added a subscriber: Unknown Object (MLST).
dsanders accepted this revision.Dec 16 2014, 2:20 AM
dsanders edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 16 2014, 2:20 AM
vmedic closed this revision.Dec 16 2014, 7:30 AM

Committed revision 224339.