Page MenuHomePhabricator

[clang-doc] Fix records in global namespace
ClosedPublic

Authored by DiegoAstiazaran on Aug 15 2019, 8:18 AM.

Details

Summary

When a Record is declared in the global namespace, clang-doc serializes it as a child of the global namespace, so the global namespace is now one if its parent namespaces. This namespace was not being included in the list of namespaces of the Info causing paths to be incorrect and the index rendered incorrectly.
Affected tests have been fixed.

Diff Detail

Repository
rL LLVM

Event Timeline

juliehockett added inline comments.Aug 15 2019, 8:55 AM
clang-tools-extra/unittests/clang-doc/SerializeTest.cpp
299 ↗(On Diff #215406)

Native path?

434 ↗(On Diff #215406)

Native path?

DiegoAstiazaran marked 2 inline comments as done.

Fix tests that were going to fail in Windows.
Fix tests broken after rebasing.

juliehockett accepted this revision.Aug 16 2019, 8:56 AM
This revision is now accepted and ready to land.Aug 16 2019, 8:56 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2019, 9:11 AM