Page MenuHomePhabricator
Differential D65941

[OpenCL] Fix lang mode predefined macros for C++ mode
ClosedPublic
Actions

Authored by Anastasia on Aug 8 2019, 4:51 AM.

Details

Reviewers
svenvh
Commits
rG69e3c1a27b3d: Merging r368552: --------------------------------------------------------------…
rL368844: Merging r368552:
rGef58804ebc19: [OpenCL] Fix lang mode predefined macros for C++ mode.
rL368552: [OpenCL] Fix lang mode predefined macros for C++ mode.
rC368552: [OpenCL] Fix lang mode predefined macros for C++ mode.
Summary

We should only avoid adding __OPENCL_C_VERSION__, all other predefined macros about the language mode are still valid.

This change also fixes the language version check in the headers.

Diff Detail

Repository
rL LLVM

Event Timeline

Anastasia created this revision.Aug 8 2019, 4:51 AM
Herald added subscribers: ebevhan, yaxunl. · View Herald TranscriptAug 8 2019, 4:51 AM
svenvh accepted this revision.Aug 8 2019, 5:06 AM

LGTM!

This revision is now accepted and ready to land.Aug 8 2019, 5:06 AM
Closed by commit rL368552: [OpenCL] Fix lang mode predefined macros for C++ mode. (authored by stulova). · Explain WhyAug 12 2019, 3:43 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2019, 3:43 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents
Changeset List

PathSize
cfe/
trunk/
lib/
Frontend/
18 lines
Headers/
17 lines
210 lines

Diff 214597

View Options

cfe/trunk/lib/Frontend/InitPreprocessor.cpp

Loading...
View Options

cfe/trunk/lib/Headers/opencl-c-base.h

Loading...
View Options

cfe/trunk/lib/Headers/opencl-c.h

Loading...