Page MenuHomePhabricator

Remove Module::GetSymbolVendor
ClosedPublic

Authored by labath on Aug 7 2019, 5:38 AM.

Details

Summary

This patch removes the GetSymbolVendor function, and the various
mentions of the SymbolVendor in the Module class. The implementation of
GetSymbolVendor is "inlined" into the GetSymbolFile class which I
created earlier.

After this patch, the SymbolVendor class still exists inside the Module
object, but only as an implementation detail -- a fancy holder for the
SymbolFile. That will be removed in the next patch.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Aug 7 2019, 5:38 AM
JDevlieghere accepted this revision.Aug 7 2019, 9:23 AM
This revision is now accepted and ready to land.Aug 7 2019, 9:23 AM
clayborg accepted this revision.Aug 7 2019, 11:10 AM

Optional rename in inline comments, but looks good.

include/lldb/Core/Module.h
1006 ↗(On Diff #213857)

maybe name "m_did_load_symfile"?

labath marked 2 inline comments as done.Aug 8 2019, 12:23 AM
labath added inline comments.
include/lldb/Core/Module.h
1006 ↗(On Diff #213857)

good idea.

This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 12:33 AM