Page MenuHomePhabricator

[mips][microMIPS] Implement CodeGen support for SW16 and LW16 instructions
ClosedPublic

Authored by zoran.jovanovic on Dec 9 2014, 7:07 AM.

Details

Summary

Added CodeGen support for 16-bit SW16 and LW16 instructions.

Diff Detail

Repository
rL LLVM

Event Timeline

zoran.jovanovic retitled this revision from to [mips][microMIPS] Implement CodeGen support for SW16 and LW16 instructions.
zoran.jovanovic updated this object.
zoran.jovanovic edited the test plan for this revision. (Show Details)
zoran.jovanovic added a reviewer: sstankovic.
zoran.jovanovic added a subscriber: Unknown Object (MLST).

One warning removed.

Fixed issue with lw16 and reg+offset addresses.

sstankovic edited edge metadata.Feb 4 2015, 2:10 AM

LGTM, with additional comment.

lib/Target/Mips/MipsSEISelDAGToDAG.cpp
427 ↗(On Diff #19158)

I think it would be good if you add a comment for this if statement, because it behaves differently than the other similar "if (select...)" statements in this file (it returns false when the select function returns true, while the other similar statements return true when the select function returns true). The comment might be (for example):

For all the other cases where "lw" would be selected, don't select "lw16".

sstankovic accepted this revision.Feb 4 2015, 2:10 AM
sstankovic edited edge metadata.
This revision is now accepted and ready to land.Feb 4 2015, 2:10 AM
This revision was automatically updated to reflect the committed changes.