Page MenuHomePhabricator

Adding a new option to CMake to disable C++ atexit on llvm-shlib.
ClosedPublic

Authored by beanz on Dec 8 2014, 2:25 PM.

Details

Summary

This is desirable for WebKit and other clients of the llvm-shlib because C++ exit time destructors have a tendency to crash when invoked from multi-threaded applications.

Ideally this option will be temporary, because the ideal fix is to just not have exit time destructors.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 17053.Dec 8 2014, 2:25 PM
beanz retitled this revision from to Adding a new option to CMake to disable C++ atexit on llvm-shlib..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added reviewers: ributzka, chapuni.
beanz added a subscriber: Unknown Object (MLST).
ributzka accepted this revision.Dec 8 2014, 2:29 PM
ributzka edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 8 2014, 2:29 PM
Diffusion closed this revision.Dec 9 2014, 10:51 AM
Diffusion updated this revision to Diff 17086.

Closed by commit rL223805 (authored by cbieneman).

rnk added a subscriber: rnk.Dec 9 2014, 11:20 AM

How many atexit dtors do we have still? How long do you think this will stay?

Given that we had such a struggle with the other symbol override in Signals.inc, I'm surprised you went this route. :)