This is an archive of the discontinued LLVM Phabricator instance.

Differential D65715

[Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack
ClosedPublic

Authored by phosek on Aug 4 2019, 1:57 AM.

Details

Reviewers
MaskRay
mcgrathr
Commits
rG1e4f2792faf1: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack
rL367799: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack
rC367799: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack
Summary

These "sanitizers" are hardened ABIs that are wholly orthogonal
to the SanitizerCoverage instrumentation.

Diff Detail

Repository
rL LLVM

Event Timeline

mcgrathr created this revision.Aug 4 2019, 1:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2019, 1:57 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B36083: Diff 213236.Aug 4 2019, 1:57 AM
MaskRay added a comment.Aug 4 2019, 2:18 AM

Does this change affect test/Driver/fsanitize-coverage.c?

phosek commandeered this revision.Aug 4 2019, 9:28 PM
phosek updated this revision to Diff 213280.
phosek edited reviewers, added: mcgrathr; removed: phosek.
MaskRay accepted this revision.Aug 4 2019, 9:43 PM
This revision is now accepted and ready to land.Aug 4 2019, 9:43 PM
MaskRay added a comment.Aug 4 2019, 9:46 PM

Can you also take a quick look at https://reviews.llvm.org/D65699 :)

Closed by commit rL367799: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack (authored by phosek). · Explain WhyAug 4 2019, 9:48 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2019, 9:48 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
lib/
Driver/
3 lines
test/
Driver/
14 lines

Diff 213281

cfe/trunk/lib/Driver/SanitizerArgs.cpp

Show All 40 Lines
static const SanitizerMask SupportsCoverage = static const SanitizerMask SupportsCoverage =
SanitizerKind::Address | SanitizerKind::HWAddress | SanitizerKind::Address | SanitizerKind::HWAddress |
SanitizerKind::KernelAddress | SanitizerKind::KernelHWAddress | SanitizerKind::KernelAddress | SanitizerKind::KernelHWAddress |
SanitizerKind::MemTag | SanitizerKind::Memory | SanitizerKind::MemTag | SanitizerKind::Memory |
SanitizerKind::KernelMemory | SanitizerKind::Leak | SanitizerKind::KernelMemory | SanitizerKind::Leak |
SanitizerKind::Undefined | SanitizerKind::Integer | SanitizerKind::Undefined | SanitizerKind::Integer |
SanitizerKind::ImplicitConversion | SanitizerKind::Nullability | SanitizerKind::ImplicitConversion | SanitizerKind::Nullability |
SanitizerKind::DataFlow | SanitizerKind::Fuzzer | SanitizerKind::DataFlow | SanitizerKind::Fuzzer |
SanitizerKind::FuzzerNoLink | SanitizerKind::FloatDivideByZero; SanitizerKind::FuzzerNoLink | SanitizerKind::FloatDivideByZero |
SanitizerKind::SafeStack | SanitizerKind::ShadowCallStack;
static const SanitizerMask RecoverableByDefault = static const SanitizerMask RecoverableByDefault =
SanitizerKind::Undefined | SanitizerKind::Integer | SanitizerKind::Undefined | SanitizerKind::Integer |
SanitizerKind::ImplicitConversion | SanitizerKind::Nullability | SanitizerKind::ImplicitConversion | SanitizerKind::Nullability |
SanitizerKind::FloatDivideByZero; SanitizerKind::FloatDivideByZero;
static const SanitizerMask Unrecoverable = static const SanitizerMask Unrecoverable =
SanitizerKind::Unreachable | SanitizerKind::Return; SanitizerKind::Unreachable | SanitizerKind::Return;
static const SanitizerMask AlwaysRecoverable = static const SanitizerMask AlwaysRecoverable =
SanitizerKind::KernelAddress | SanitizerKind::KernelHWAddress; SanitizerKind::KernelAddress | SanitizerKind::KernelHWAddress;
▲ Show 20 Lines • Show All 1,075 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/fsanitize-coverage.c

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines
// CLANG-CL-COVERAGE-NOT: error: // CLANG-CL-COVERAGE-NOT: error:
// CLANG-CL-COVERAGE-NOT: warning: // CLANG-CL-COVERAGE-NOT: warning:
// CLANG-CL-COVERAGE-NOT: argument unused // CLANG-CL-COVERAGE-NOT: argument unused
// CLANG-CL-COVERAGE-NOT: unknown argument // CLANG-CL-COVERAGE-NOT: unknown argument
// CLANG-CL-COVERAGE: -fsanitize-coverage-type=1 // CLANG-CL-COVERAGE: -fsanitize-coverage-type=1
// CLANG-CL-COVERAGE: -fsanitize=address // CLANG-CL-COVERAGE: -fsanitize=address
// RUN: %clang -target x86_64-linux-gnu -fsanitize=safe-stack -fsanitize-coverage=trace-pc-guard %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VS-SAFESTACK // RUN: %clang -target x86_64-linux-gnu -fsanitize=safe-stack -fsanitize-coverage=trace-pc-guard %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VS-SAFESTACK
// CHECK-VS-SAFESTACK: -fsanitize-coverage-trace-pc-guard
// CHECK-VS-SAFESTACK: -fsanitize=safe-stack // CHECK-VS-SAFESTACK: -fsanitize=safe-stack
// CHECK-VS-SAFESTACK-NOT: -fsanitize-coverage-trace-pc-guard
// RUN: %clang -target x86_64-linux-gnu -fsanitize=safe-stack -fsanitize-coverage=trace-pc-guard -fno-sanitize=safe-stack %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-NO-SAFESTACK // RUN: %clang -target x86_64-linux-gnu -fsanitize=safe-stack -fsanitize-coverage=trace-pc-guard -fno-sanitize=safe-stack %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-NO-SAFESTACK
// CHECK-NO-SAFESTACK-NOT: error: // CHECK-NO-SAFESTACK-NOT: error:
// CHECK-NO-SAFESTACK-NOT: warning: // CHECK-NO-SAFESTACK-NOT: warning:
// CHECK-NO-SAFESTACK-NOT: argument unused // CHECK-NO-SAFESTACK-NOT: argument unused
// CHECK-NO-SAFESTACK-NOT: unknown argument // CHECK-NO-SAFESTACK-NOT: unknown argument
// CHECK-NO-SAFESTACK-NOT: -fsanitize=safe-stack // CHECK-NO-SAFESTACK-NOT: -fsanitize=safe-stack
// CHECK-NO-SAFESTACK: -fsanitize-coverage-trace-pc-guard // CHECK-NO-SAFESTACK: -fsanitize-coverage-trace-pc-guard
// RUN: %clang -target x86_64-linux-gnu -fsanitize=shadow-call-stack -fsanitize-coverage=trace-pc-guard %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VS-SHADOWCALLSTACK
// CHECK-VS-SHADOWCALLSTACK: -fsanitize-coverage-trace-pc-guard
// CHECK-VS-SHADOWCALLSTACK: -fsanitize=shadow-call-stack
// RUN: %clang -target x86_64-linux-gnu -fsanitize=shadow-call-stack -fsanitize-coverage=trace-pc-guard -fno-sanitize=shadow-call-stack %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-NO-SAFESTACK
// CHECK-NO-SHADOWCALLSTACK-NOT: error:
// CHECK-NO-SHADOWCALLSTACK-NOT: warning:
// CHECK-NO-SHADOWCALLSTACK-NOT: argument unused
// CHECK-NO-SHADOWCALLSTACK-NOT: unknown argument
// CHECK-NO-SHADOWCALLSTACK-NOT: -fsanitize=shadow-call-stack
// CHECK-NO-SHADOWCALLSTACK: -fsanitize-coverage-trace-pc-guard