Index: clang/include/clang/Basic/DiagnosticSemaKinds.td =================================================================== --- clang/include/clang/Basic/DiagnosticSemaKinds.td +++ clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -3287,6 +3287,10 @@ def warn_non_literal_null_pointer : Warning< "expression which evaluates to zero treated as a null pointer constant of " "type %0">, InGroup; +def warn_pointer_compare : Warning< + "comparing a pointer to a null character constant; did you mean " + "to compare to %0?">, + InGroup>; def warn_impcast_null_pointer_to_integer : Warning< "implicit conversion of %select{NULL|nullptr}0 constant to %1">, InGroup; Index: clang/include/clang/Sema/Sema.h =================================================================== --- clang/include/clang/Sema/Sema.h +++ clang/include/clang/Sema/Sema.h @@ -9991,6 +9991,7 @@ QualType CheckShiftOperands( // C99 6.5.7 ExprResult &LHS, ExprResult &RHS, SourceLocation Loc, BinaryOperatorKind Opc, bool IsCompAssign = false); + void CheckNullCharToNullptr(ExprResult &E, ExprResult &NullE); QualType CheckCompareOperands( // C99 6.5.8/9 ExprResult &LHS, ExprResult &RHS, SourceLocation Loc, BinaryOperatorKind Opc); Index: clang/lib/Sema/SemaExpr.cpp =================================================================== --- clang/lib/Sema/SemaExpr.cpp +++ clang/lib/Sema/SemaExpr.cpp @@ -10433,6 +10433,36 @@ return S.Context.getLogicalOperationType(); } +void Sema::CheckNullCharToNullptr(ExprResult &E, ExprResult &NullE) { + if (!NullE.get()->getType()->isAnyPointerType()) + return; + StringRef NullValue; + if (getLangOpts().CPlusPlus11) + NullValue = "nullptr"; + else if (PP.isMacroDefined("NULL")) + NullValue = "NULL"; + else + NullValue = "(void *) 0"; + if (!E.get()->getType()->isAnyPointerType() && + E.get()->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull) == + Expr::NPCK_ZeroExpression) { + if (const auto *CL = dyn_cast(E.get())) { + if (CL->getValue() == 0) + Diag(E.get()->getExprLoc(), diag::warn_pointer_compare) + << NullValue + << FixItHint::CreateReplacement(E.get()->getExprLoc(), NullValue); + } + else if (const auto *CE = dyn_cast(E.get())) { + TypeSourceInfo *TI = CE->getTypeInfoAsWritten(); + QualType T = Context.getCanonicalType(TI->getType()).getUnqualifiedType(); + if (T == Context.CharTy) + Diag(E.get()->getExprLoc(), diag::warn_pointer_compare) + << NullValue + << FixItHint::CreateReplacement(E.get()->getExprLoc(), NullValue); + } + } +} + // C99 6.5.8, C++ [expr.rel] QualType Sema::CheckCompareOperands(ExprResult &LHS, ExprResult &RHS, SourceLocation Loc, @@ -10466,6 +10496,8 @@ } checkArithmeticNull(*this, LHS, RHS, Loc, /*isCompare=*/true); + CheckNullCharToNullptr(LHS, RHS); + CheckNullCharToNullptr(RHS, LHS); // Handle vector comparisons separately. if (LHS.get()->getType()->isVectorType() || Index: clang/test/Sema/warn-nullchar-nullptr.c =================================================================== --- /dev/null +++ clang/test/Sema/warn-nullchar-nullptr.c @@ -0,0 +1,45 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -Wall %s + +int test1(int *a) { + return a == '\0'; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to (void *) 0?}} +} + +int test2(int *a) { + return '\0' == a; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to (void *) 0?}} +} + +int test3(int *a) { + return a == L'\0'; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to (void *) 0?}} +} + +int test4(int *a) { + return a == u'\0'; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to (void *) 0?}} +} + +int test5(int *a) { + return a == U'\0'; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to (void *) 0?}} +} + +int test6(int *a) { + return a == (char)0; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to (void *) 0?}} +} + +typedef char my_char; +int test7(int *a) { + return a == (my_char)0; + // expected-warning@-1 {{comparing a pointer to a null character constant; did you mean to compare to (void *) 0?}} +} + +int test8(int *a) { + return a != '\0'; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to (void *) 0?}} +} + +#define NULL (void *)0 +int test9(int *a) { + return a == '\0'; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to NULL?}} +} + +#define MYCHAR char +int test10(int *a) { + return a == (MYCHAR)0; // expected-warning {{comparing a pointer to a null character constant; did you mean to compare to NULL?}} +}