Page MenuHomePhabricator

[clangd] Fix a regression in rL366996.
ClosedPublic

Authored by hokein on Jul 30 2019, 6:17 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Jul 30 2019, 6:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 6:17 AM
hokein updated this revision to Diff 212329.Jul 30 2019, 6:23 AM

oops, forgot a change.

jvikstrom accepted this revision.Jul 30 2019, 6:54 AM
jvikstrom added inline comments.
clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp
43 ↗(On Diff #212329)

Shouldn't intently -> instantly?

This revision is now accepted and ready to land.Jul 30 2019, 6:54 AM
hokein marked 2 inline comments as done.Jul 30 2019, 7:17 AM
hokein added inline comments.
clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp
43 ↗(On Diff #212329)

ah, I mean intendedly.

This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 7:21 AM