This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Also include the array definition in Properties.inc
ClosedPublic

Authored by JDevlieghere on Jul 26 2019, 2:59 PM.

Details

Summary

Right now our Properties.inc only generates the initializer for the options list but
not the array declaration boilerplate around it. As the array definition is identical for all arrays,
we might as well also let the Properties.inc generate it alongside the initializers.

Unfortunately we cannot do the same for enums, as there's this magic ePropertyExperimental,
which needs to come at the end to be interpreted correctly. Hopefully we can get rid of this in
the future and do the same for the property enums.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Jul 26 2019, 2:59 PM
teemperor accepted this revision.Jul 29 2019, 5:06 AM

LGTM beside a small nit pick.

lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp
150 ↗(On Diff #212013)

Is this like a placeholder for supporting enums? I think a FIXME or TODO would be more appropriate. (Feel free to ignore this if you already have a patch lined up for enums and this will be instantly overwritten)

This revision is now accepted and ready to land.Jul 29 2019, 5:06 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2019, 9:42 AM