Index: cfe/trunk/lib/Sema/SemaInit.cpp =================================================================== --- cfe/trunk/lib/Sema/SemaInit.cpp +++ cfe/trunk/lib/Sema/SemaInit.cpp @@ -6568,19 +6568,33 @@ if (auto *Conv = dyn_cast_or_null(Callee)) if (isRecordWithAttr(Conv->getConversionType())) return true; - if (!Callee->getParent()->isInStdNamespace() || !Callee->getIdentifier()) + if (!Callee->getParent()->isInStdNamespace()) return false; if (!isRecordWithAttr(Callee->getThisObjectType()) && !isRecordWithAttr(Callee->getThisObjectType())) return false; - if (!isRecordWithAttr(Callee->getReturnType()) && - !Callee->getReturnType()->isPointerType()) - return false; - return llvm::StringSwitch(Callee->getName()) - .Cases("begin", "rbegin", "cbegin", "crbegin", true) - .Cases("end", "rend", "cend", "crend", true) - .Cases("c_str", "data", "get", true) - .Default(false); + if (Callee->getReturnType()->isPointerType() || + isRecordWithAttr(Callee->getReturnType())) { + if (!Callee->getIdentifier()) + return false; + return llvm::StringSwitch(Callee->getName()) + .Cases("begin", "rbegin", "cbegin", "crbegin", true) + .Cases("end", "rend", "cend", "crend", true) + .Cases("c_str", "data", "get", true) + // Map and set types. + .Cases("find", "equal_range", "lower_bound", "upper_bound", true) + .Default(false); + } else if (Callee->getReturnType()->isReferenceType()) { + if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || + OO == OverloadedOperatorKind::OO_Star; + } + return llvm::StringSwitch(Callee->getName()) + .Cases("front", "back", "at", true) + .Default(false); + } + return false; } static void handleGslAnnotatedTypes(IndirectLocalPath &Path, Expr *Call, @@ -6600,6 +6614,12 @@ if (MD && shouldTrackImplicitObjectArg(MD)) VisitPointerArg(MD, MCE->getImplicitObjectArgument()); return; + } else if (auto *OCE = dyn_cast(Call)) { + FunctionDecl *Callee = OCE->getDirectCallee(); + if (Callee->isCXXInstanceMember() && + shouldTrackImplicitObjectArg(cast(Callee))) + VisitPointerArg(Callee, OCE->getArg(0)); + return; } if (auto *CCE = dyn_cast(Call)) { Index: cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp =================================================================== --- cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp +++ cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp @@ -121,24 +121,47 @@ namespace std { template -struct basic_iterator {}; +struct basic_iterator { + basic_iterator operator++(); + T& operator*(); +}; + +template +bool operator!=(basic_iterator, basic_iterator); template struct vector { typedef basic_iterator iterator; iterator begin(); + iterator end(); T *data(); + T &at(int n); +}; + +template +struct basic_string_view { + basic_string_view(const T *); + const T *begin() const; }; template struct basic_string { const T *c_str() const; + operator basic_string_view () const; }; + template struct unique_ptr { T *get() const; }; + +template +struct optional { + optional(); + optional(const T&); + T &operator*(); +}; } void modelIterators() { @@ -168,3 +191,29 @@ int *danglingUniquePtrFromTemp2() { return std::unique_ptr().get(); // expected-warning {{returning address of local temporary object}} } + +void danglingReferenceFromTempOwner() { + int &r = *std::optional(); // expected-warning {{object backing the pointer will be destroyed at the end of the full-expression}} + int &r2 = *std::optional(5); // expected-warning {{object backing the pointer will be destroyed at the end of the full-expression}} + int &r3 = std::vector().at(3); // expected-warning {{object backing the pointer will be destroyed at the end of the full-expression}} +} + +std::vector getTempVec(); +std::optional> getTempOptVec(); + +int &usedToBeFalsePositive(std::vector &v) { + std::vector::iterator it = v.begin(); + int& value = *it; + return value; // ok +} + +int &doNotFollowReferencesForLocalOwner() { + std::unique_ptr localOwner; + int &p = *localOwner.get(); + // In real world code localOwner is usually moved here. + return p; // ok +} + +const char *trackThroughMultiplePointer() { + return std::basic_string_view(std::basic_string()).begin(); // expected-warning {{returning address of local temporary object}} +}