This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Select G_AND/G_OR/G_XOR
ClosedPublic

Authored by arsenm on Jul 15 2019, 5:58 AM.

Details

Reviewers
tstellar
nhaehnle

Diff Detail

Event Timeline

arsenm created this revision.Jul 15 2019, 5:58 AM
tstellar accepted this revision.Jul 15 2019, 7:45 AM

LGTM.

This revision is now accepted and ready to land.Jul 15 2019, 7:45 AM
tstellar added inline comments.Jul 15 2019, 7:46 AM
lib/Target/AMDGPU/AMDGPUInstructionSelector.h
75

Would we be able to do this in TableGen if we didn't have to special case the boolean values?

arsenm marked an inline comment as done.Jul 15 2019, 7:48 AM
arsenm added inline comments.
lib/Target/AMDGPU/AMDGPUInstructionSelector.h
75

I think so

arsenm closed this revision.Jul 15 2019, 12:49 PM

r366121