Index: include/llvm/Object/ELF.h =================================================================== --- include/llvm/Object/ELF.h +++ include/llvm/Object/ELF.h @@ -466,9 +466,10 @@ if (!Index) // no section string table. return ""; + // TODO: Test a case when the sh_link of the section with index 0 is broken. if (Index >= Sections.size()) - // TODO: this error is untested. - return createError("invalid section index"); + return createError("section header string table index " + Twine(Index) + + " does not exist"); return getStringTable(&Sections[Index]); } Index: test/Object/invalid.test =================================================================== --- test/Object/invalid.test +++ test/Object/invalid.test @@ -536,3 +536,19 @@ FileSize: 0xffff0000 Sections: - Section: .dynamic + +# RUN: yaml2obj --docnum=25 %s -o %t25 +# RUN: not obj2yaml 2>&1 %t25 | FileCheck %s -DFILE=%t25 --check-prefix=INVALID-SHSTRNDX + +# INVALID-SHSTRNDX: Error reading file: [[FILE]]: section header string table index 255 does not exist + +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data: ELFDATA2LSB + Type: ET_REL + Machine: EM_X86_64 + SHStrNdx: 0xFF +Sections: + - Name: .foo + Type: SHT_PROGBITS Index: test/tools/llvm-readobj/elf-invalid-shstrndx.test =================================================================== --- /dev/null +++ test/tools/llvm-readobj/elf-invalid-shstrndx.test @@ -0,0 +1,26 @@ +# RUN: yaml2obj %s -o %t +# RUN: not llvm-readelf --headers -S 2>&1 %t | FileCheck %s -DFILE=%t --check-prefix=GNU +# RUN: not llvm-readobj --headers -S 2>&1 %t | FileCheck %s -DFILE=%t --check-prefix=LLVM + +# GNU: ELF Header: +# GNU: Section header string table index: 255 +# GNU-NEXT: There are 4 section headers, starting at offset 0x40: +# GNU: Section Headers: +# GNU-NEXT: [Nr] Name +# GNU-EMPTY: +# GNU-NEXT: error: '[[FILE]]': section header string table index 255 does not exist + +# LLVM: ElfHeader { +# LLVM: StringTableSectionIndex: 255 +# LLVM-NEXT: } +# LLVM-NEXT: Sections [ +# LLVM-EMPTY: +# LLVM-NEXT: error: '[[FILE]]': section header string table index 255 does not exist + +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data: ELFDATA2LSB + Type: ET_REL + Machine: EM_X86_64 + SHStrNdx: 0xFF Index: tools/llvm-readobj/ELFDumper.cpp =================================================================== --- tools/llvm-readobj/ELFDumper.cpp +++ tools/llvm-readobj/ELFDumper.cpp @@ -183,6 +183,8 @@ void printELFLinkerOptions() override; + const object::ELFObjectFile *getElfObject() const { return ObjF; }; + private: std::unique_ptr> ELFDumperStyle; @@ -3009,15 +3011,19 @@ template static StringRef getSectionName(const typename ELFT::Shdr &Sec, - const ELFFile &Obj, + const ELFObjectFile &ElfObj, ArrayRef Sections) { + const ELFFile &Obj = *ElfObj.getELFFile(); uint32_t Index = Obj.getHeader()->e_shstrndx; if (Index == ELF::SHN_XINDEX) Index = Sections[0].sh_link; if (!Index) // no section string table. return ""; + // TODO: Test a case when the sh_link of the section with index 0 is broken. if (Index >= Sections.size()) - reportError("invalid section index"); + reportError(ElfObj.getFileName(), + createError("section header string table index " + + Twine(Index) + " does not exist")); StringRef Data = toStringRef(unwrapOrError( Obj.template getSectionContentsAsArray(&Sections[Index]))); return unwrapOrError(Obj.getSectionName(&Sec, Data)); @@ -3040,10 +3046,11 @@ printField(F); OS << "\n"; + const ELFObjectFile *ElfObj = this->dumper()->getElfObject(); size_t SectionIndex = 0; for (const Elf_Shdr &Sec : Sections) { Fields[0].Str = to_string(SectionIndex); - Fields[1].Str = getSectionName(Sec, *Obj, Sections); + Fields[1].Str = getSectionName(Sec, *ElfObj, Sections); Fields[2].Str = getSectionTypeString(Obj->getHeader()->e_machine, Sec.sh_type); Fields[3].Str = @@ -4590,8 +4597,9 @@ int SectionIndex = -1; ArrayRef Sections = unwrapOrError(Obj->sections()); + const ELFObjectFile *ElfObj = this->dumper()->getElfObject(); for (const Elf_Shdr &Sec : Sections) { - StringRef Name = getSectionName(Sec, *Obj, Sections); + StringRef Name = getSectionName(Sec, *ElfObj, Sections); DictScope SectionD(W, "Section"); W.printNumber("Index", ++SectionIndex); W.printNumber("Name", Name, Sec.sh_name); Index: tools/llvm-readobj/llvm-readobj.h =================================================================== --- tools/llvm-readobj/llvm-readobj.h +++ tools/llvm-readobj/llvm-readobj.h @@ -22,6 +22,7 @@ // Various helper functions. LLVM_ATTRIBUTE_NORETURN void reportError(Twine Msg); + void reportError(StringRef Input, Error Err); void reportWarning(Twine Msg); void warn(llvm::Error Err); void error(std::error_code EC); Index: tools/llvm-readobj/llvm-readobj.cpp =================================================================== --- tools/llvm-readobj/llvm-readobj.cpp +++ tools/llvm-readobj/llvm-readobj.cpp @@ -371,11 +371,18 @@ namespace llvm { LLVM_ATTRIBUTE_NORETURN void reportError(Twine Msg) { + fouts().flush(); errs() << "\n"; WithColor::error(errs()) << Msg << "\n"; exit(1); } +void reportError(StringRef Input, Error Err) { + if (Input == "-") + Input = ""; + error(createFileError(Input, std::move(Err))); +} + void reportWarning(Twine Msg) { fouts().flush(); errs() << "\n"; @@ -403,12 +410,6 @@ } // namespace llvm -static void reportError(StringRef Input, Error Err) { - if (Input == "-") - Input = ""; - error(createFileError(Input, std::move(Err))); -} - static void reportError(StringRef Input, std::error_code EC) { reportError(Input, errorCodeToError(EC)); }