Page MenuHomePhabricator

Add convenience methods to convert LLDB to LLVM data structures.
ClosedPublic

Authored by JDevlieghere on Jul 10 2019, 2:49 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Jul 10 2019, 2:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 2:49 PM
Herald added a subscriber: aprantl. · View Herald Transcript

Just wondering if we want to cache the llvm::DWARFContext in the LLDB DWARFContext. See inline comments.

lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.h
69 ↗(On Diff #209072)

Should we cache this lldb's DWARFContext and just hand out a pointer or reference that is owned by this class? Or are we ok creating temp llvm::DWARFContext objects that we will throw away? Is there any state in llvm::DWARFContext that we wouldn't want to re-create or parse is my main concern.

Cache the LLVM DWARF context.

Update use in debug names.

clayborg accepted this revision.Jul 11 2019, 7:23 AM
This revision is now accepted and ready to land.Jul 11 2019, 7:23 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 1:28 PM