Page MenuHomePhabricator

[ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest.
ClosedPublic

Authored by balazske on Jul 10 2019, 5:50 AM.

Details

Summary

These tests may work with C++14 language constructs in the future
(variable templates and others).
To avoid warnings about language version C++ version constants in the tests
are updated.

Diff Detail

Repository
rL LLVM

Event Timeline

balazske created this revision.Jul 10 2019, 5:50 AM
martong accepted this revision.Jul 10 2019, 6:40 AM
This revision is now accepted and ready to land.Jul 10 2019, 6:40 AM

Probably change to CXX14?

balazske retitled this revision from [ASTImporter] Using Lang_CXX11 in ASTImporterVisibilityTest. to [ASTImporter] Using Lang_CXX14 in ASTImporterVisibilityTest..Jul 15 2019, 12:34 AM
balazske edited the summary of this revision. (Show Details)
balazske updated this revision to Diff 209768.Jul 15 2019, 12:37 AM
  • Change to Lang_CXX14.
martong accepted this revision.Jul 15 2019, 3:00 AM

Does it really matter if it is CXX11 or CXX14, in the child patch we use a CXX11 using directive. Anyway, CXX14 is more future proof.

Does it really matter if it is CXX11 or CXX14, in the child patch we use a CXX11 using directive. Anyway, CXX14 is more future proof.

Later there should follow the test with variable template that produces warnings again if not Lang_CXX14 is used.

Does it really matter if it is CXX11 or CXX14, in the child patch we use a CXX11 using directive. Anyway, CXX14 is more future proof.

Later there should follow the test with variable template that produces warnings again if not Lang_CXX14 is used.

Ok 👍

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2019, 5:17 AM