This is an archive of the discontinued LLVM Phabricator instance.

[llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build
ClosedPublic

Authored by stella.stamenova on Jul 8 2019, 11:31 AM.

Download Raw Diff

Details

Reviewers

Commits

rG032e3c468fab: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build
rL366097: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build

Summary

Occasionally the build of LLVMLibDriver will fail because Attributes.inc has not been generated yet. Add an explicit dependency, so that we can guarantee that the file has been generated before LLVMLibDriver is build.

[error]llvm\include\llvm\IR\Attributes.h(73,0): Error C1083: Cannot open include file: 'llvm/IR/Attributes.inc': No such file or directory

llvm\include\llvm/IR/Attributes.h(73): fatal error C1083: Cannot open include file: 'llvm/IR/Attributes.inc': No such file or directory [LLVMLibDriver.vcxproj]

Diff Detail

Repository: rL LLVM

Event Timeline

stella.stamenova created this revision.Jul 8 2019, 11:31 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2019, 11:31 AM

Herald added subscribers: llvm-commits, hiraditya, mgorny. · View Herald Transcript

This revision was not accepted when it landed; it landed in state Needs Review.Jul 15 2019, 11:15 AM

Closed by commit rL366097: [llvm-lib] Add a dependency to intrinsics_gen to the LLVMLibDriver build (authored by stella.stamenova). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

lib/

ToolDrivers/

llvm-lib/

CMakeLists.txt

3 lines

Diff 209918

llvm/trunk/lib/ToolDrivers/llvm-lib/CMakeLists.txt

	set(LLVM_LINK_COMPONENTS			set(LLVM_LINK_COMPONENTS
	BinaryFormat			BinaryFormat
	BitReader			BitReader
	Object			Object
	Option			Option
	Support			Support
	)			)

	set(LLVM_TARGET_DEFINITIONS Options.td)			set(LLVM_TARGET_DEFINITIONS Options.td)
	tablegen(LLVM Options.inc -gen-opt-parser-defs)			tablegen(LLVM Options.inc -gen-opt-parser-defs)
	add_public_tablegen_target(LibOptionsTableGen)			add_public_tablegen_target(LibOptionsTableGen)

	add_llvm_library(LLVMLibDriver			add_llvm_library(LLVMLibDriver
	LibDriver.cpp			LibDriver.cpp

				DEPENDS
				intrinsics_gen
	)			)
	add_dependencies(LLVMLibDriver LibOptionsTableGen)			add_dependencies(LLVMLibDriver LibOptionsTableGen)