Index: lib/Transforms/InstCombine/InstCombineAddSub.cpp =================================================================== --- lib/Transforms/InstCombine/InstCombineAddSub.cpp +++ lib/Transforms/InstCombine/InstCombineAddSub.cpp @@ -895,6 +895,10 @@ if (match(Op0, m_Not(m_Value(X)))) return BinaryOperator::CreateSub(SubOne(Op1C), X); + // add (add (xor X, -1), Y), 1 --> sub Y, X + if (match(&Add, m_Add(m_c_Add(m_Not(m_Value(X)), m_Value(Y)), m_One()))) + return BinaryOperator::CreateSub(Y, X); + const APInt *C; if (!match(Op1, m_APInt(C))) return nullptr; Index: test/Transforms/InstCombine/add.ll =================================================================== --- test/Transforms/InstCombine/add.ll +++ test/Transforms/InstCombine/add.ll @@ -951,9 +951,7 @@ define i32 @add_to_sub(i32 %M, i32 %B) { ; CHECK-LABEL: @add_to_sub( ; CHECK-NEXT: [[A:%.*]] = mul i32 [[M:%.*]], 42 -; CHECK-NEXT: [[C:%.*]] = xor i32 [[B:%.*]], -1 -; CHECK-NEXT: [[D:%.*]] = add i32 [[A]], [[C]] -; CHECK-NEXT: [[E:%.*]] = add i32 [[D]], 1 +; CHECK-NEXT: [[E:%.*]] = sub i32 [[A]], [[B:%.*]] ; CHECK-NEXT: ret i32 [[E]] ; %A = mul i32 %M, 42 ; thwart complexity-based ordering @@ -966,10 +964,8 @@ ; E = (~B + A) + 1 = A - B define i32 @add_to_sub2(i32 %A, i32 %M) { ; CHECK-LABEL: @add_to_sub2( -; CHECK-NEXT: [[B:%.*]] = mul i32 [[M:%.*]], 42 -; CHECK-NEXT: [[C:%.*]] = xor i32 [[B]], -1 -; CHECK-NEXT: [[D:%.*]] = add i32 [[C]], [[A:%.*]] -; CHECK-NEXT: [[E:%.*]] = add i32 [[D]], 1 +; CHECK-NEXT: [[TMP1:%.*]] = mul i32 [[M:%.*]], -42 +; CHECK-NEXT: [[E:%.*]] = add i32 [[TMP1]], [[A:%.*]] ; CHECK-NEXT: ret i32 [[E]] ; %B = mul i32 %M, 42 ; thwart complexity-based ordering Index: test/Transforms/InstCombine/fold-inc-of-add-of-not-x-and-y-to-sub-x-from-y.ll =================================================================== --- test/Transforms/InstCombine/fold-inc-of-add-of-not-x-and-y-to-sub-x-from-y.ll +++ test/Transforms/InstCombine/fold-inc-of-add-of-not-x-and-y-to-sub-x-from-y.ll @@ -12,9 +12,7 @@ define i32 @t0(i32 %x, i32 %y) { ; CHECK-LABEL: @t0( -; CHECK-NEXT: [[T0:%.*]] = xor i32 [[X:%.*]], -1 -; CHECK-NEXT: [[T1:%.*]] = add i32 [[T0]], [[Y:%.*]] -; CHECK-NEXT: [[T2:%.*]] = add i32 [[T1]], 1 +; CHECK-NEXT: [[T2:%.*]] = sub i32 [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: ret i32 [[T2]] ; %t0 = xor i32 %x, -1 @@ -29,9 +27,7 @@ define <4 x i32> @t1_vec_splat(<4 x i32> %x, <4 x i32> %y) { ; CHECK-LABEL: @t1_vec_splat( -; CHECK-NEXT: [[T0:%.*]] = xor <4 x i32> [[X:%.*]], -; CHECK-NEXT: [[T1:%.*]] = add <4 x i32> [[T0]], [[Y:%.*]] -; CHECK-NEXT: [[T2:%.*]] = add <4 x i32> [[T1]], +; CHECK-NEXT: [[T2:%.*]] = sub <4 x i32> [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: ret <4 x i32> [[T2]] ; %t0 = xor <4 x i32> %x, @@ -42,9 +38,7 @@ define <4 x i32> @t2_vec_undef0(<4 x i32> %x, <4 x i32> %y) { ; CHECK-LABEL: @t2_vec_undef0( -; CHECK-NEXT: [[T0:%.*]] = xor <4 x i32> [[X:%.*]], -; CHECK-NEXT: [[T1:%.*]] = add <4 x i32> [[T0]], [[Y:%.*]] -; CHECK-NEXT: [[T2:%.*]] = add <4 x i32> [[T1]], +; CHECK-NEXT: [[T2:%.*]] = sub <4 x i32> [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: ret <4 x i32> [[T2]] ; %t0 = xor <4 x i32> %x, @@ -55,9 +49,7 @@ define <4 x i32> @t3_vec_undef1(<4 x i32> %x, <4 x i32> %y) { ; CHECK-LABEL: @t3_vec_undef1( -; CHECK-NEXT: [[T0:%.*]] = xor <4 x i32> [[X:%.*]], -; CHECK-NEXT: [[T1:%.*]] = add <4 x i32> [[T0]], [[Y:%.*]] -; CHECK-NEXT: [[T2:%.*]] = add <4 x i32> [[T1]], +; CHECK-NEXT: [[T2:%.*]] = sub <4 x i32> [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: ret <4 x i32> [[T2]] ; %t0 = xor <4 x i32> %x, @@ -68,9 +60,7 @@ define <4 x i32> @t4_vec_undef2(<4 x i32> %x, <4 x i32> %y) { ; CHECK-LABEL: @t4_vec_undef2( -; CHECK-NEXT: [[T0:%.*]] = xor <4 x i32> [[X:%.*]], -; CHECK-NEXT: [[T1:%.*]] = add <4 x i32> [[T0]], [[Y:%.*]] -; CHECK-NEXT: [[T2:%.*]] = add <4 x i32> [[T1]], +; CHECK-NEXT: [[T2:%.*]] = sub <4 x i32> [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: ret <4 x i32> [[T2]] ; %t0 = xor <4 x i32> %x, @@ -89,8 +79,7 @@ ; CHECK-LABEL: @t5( ; CHECK-NEXT: [[T0:%.*]] = xor i32 [[X:%.*]], -1 ; CHECK-NEXT: call void @use32(i32 [[T0]]) -; CHECK-NEXT: [[T1:%.*]] = add i32 [[T0]], [[Y:%.*]] -; CHECK-NEXT: [[T2:%.*]] = add i32 [[T1]], 1 +; CHECK-NEXT: [[T2:%.*]] = sub i32 [[Y:%.*]], [[X]] ; CHECK-NEXT: ret i32 [[T2]] ; %t0 = xor i32 %x, -1 @@ -105,7 +94,7 @@ ; CHECK-NEXT: [[T0:%.*]] = xor i32 [[X:%.*]], -1 ; CHECK-NEXT: [[T1:%.*]] = add i32 [[T0]], [[Y:%.*]] ; CHECK-NEXT: call void @use32(i32 [[T1]]) -; CHECK-NEXT: [[T2:%.*]] = add i32 [[T1]], 1 +; CHECK-NEXT: [[T2:%.*]] = sub i32 [[Y]], [[X]] ; CHECK-NEXT: ret i32 [[T2]] ; %t0 = xor i32 %x, -1 @@ -121,7 +110,7 @@ ; CHECK-NEXT: call void @use32(i32 [[T0]]) ; CHECK-NEXT: [[T1:%.*]] = add i32 [[T0]], [[Y:%.*]] ; CHECK-NEXT: call void @use32(i32 [[T1]]) -; CHECK-NEXT: [[T2:%.*]] = add i32 [[T1]], 1 +; CHECK-NEXT: [[T2:%.*]] = sub i32 [[Y]], [[X]] ; CHECK-NEXT: ret i32 [[T2]] ; %t0 = xor i32 %x, -1 @@ -141,9 +130,7 @@ define i32 @t8_commutative(i32 %x) { ; CHECK-LABEL: @t8_commutative( ; CHECK-NEXT: [[Y:%.*]] = call i32 @gen32() -; CHECK-NEXT: [[T0:%.*]] = xor i32 [[X:%.*]], -1 -; CHECK-NEXT: [[T1:%.*]] = add i32 [[Y]], [[T0]] -; CHECK-NEXT: [[T2:%.*]] = add i32 [[T1]], 1 +; CHECK-NEXT: [[T2:%.*]] = sub i32 [[Y]], [[X:%.*]] ; CHECK-NEXT: ret i32 [[T2]] ; %y = call i32 @gen32() Index: test/Transforms/InstCombine/sub-minmax.ll =================================================================== --- test/Transforms/InstCombine/sub-minmax.ll +++ test/Transforms/InstCombine/sub-minmax.ll @@ -128,8 +128,7 @@ ; CHECK-NEXT: [[TMP1:%.*]] = icmp ugt i32 [[A:%.*]], -32 ; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 [[A]], i32 -32 ; CHECK-NEXT: [[L1:%.*]] = xor i32 [[TMP2]], -1 -; CHECK-NEXT: [[TMP3:%.*]] = add i32 [[L1]], [[A]] -; CHECK-NEXT: [[X:%.*]] = add i32 [[TMP3]], 1 +; CHECK-NEXT: [[X:%.*]] = sub i32 [[A]], [[TMP2]] ; CHECK-NEXT: call void @use32(i32 [[L1]]) ; CHECK-NEXT: ret i32 [[X]] ; @@ -302,8 +301,7 @@ ; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i8 [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i8 [[X]], i8 [[Y]] ; CHECK-NEXT: [[MINXY:%.*]] = xor i8 [[TMP2]], -1 -; CHECK-NEXT: [[TMP3:%.*]] = add i8 [[MINXY]], [[X]] -; CHECK-NEXT: [[SUBX:%.*]] = add i8 [[TMP3]], 1 +; CHECK-NEXT: [[SUBX:%.*]] = sub i8 [[X]], [[TMP2]] ; CHECK-NEXT: [[SUBY:%.*]] = sub i8 [[Y]], [[TMP2]] ; CHECK-NEXT: call void @use8(i8 [[SUBX]]) ; CHECK-NEXT: call void @use8(i8 [[SUBY]])