Index: COFF/Writer.cpp =================================================================== --- COFF/Writer.cpp +++ COFF/Writer.cpp @@ -219,6 +219,7 @@ void sortExceptionTable(); void sortCRTSectionChunks(std::vector &Chunks); void addSyntheticIdata(); + void fixPartialSectionChars(StringRef Name, uint32_t Chars); bool fixGnuImportChunks(); PartialSection *createPartialSection(StringRef Name, uint32_t OutChars); PartialSection *findPartialSection(StringRef Name, uint32_t OutChars); @@ -652,6 +653,22 @@ }); } +void Writer::fixPartialSectionChars(StringRef Name, uint32_t Chars) { + for (auto It : PartialSections) { + PartialSection *PSec = It.second; + StringRef CurName = PSec->Name; + if (!CurName.consume_front(Name) || + (!CurName.empty() && !CurName.startswith("$"))) + continue; + if (PSec->Characteristics == Chars) + continue; + PartialSection *DestSec = createPartialSection(PSec->Name, Chars); + DestSec->Chunks.insert(DestSec->Chunks.end(), PSec->Chunks.begin(), + PSec->Chunks.end()); + PSec->Chunks.clear(); + } +} + // Sort concrete section chunks from GNU import libraries. // // GNU binutils doesn't use short import files, but instead produces import @@ -667,17 +684,7 @@ // Make sure all .idata$* section chunks are mapped as RDATA in order to // be sorted into the same sections as our own synthesized .idata chunks. - for (auto It : PartialSections) { - PartialSection *PSec = It.second; - if (!PSec->Name.startswith(".idata")) - continue; - if (PSec->Characteristics == RDATA) - continue; - PartialSection *RDataSec = createPartialSection(PSec->Name, RDATA); - RDataSec->Chunks.insert(RDataSec->Chunks.end(), PSec->Chunks.begin(), - PSec->Chunks.end()); - PSec->Chunks.clear(); - } + fixPartialSectionChars(".idata", RDATA); bool HasIdata = false; // Sort all .idata$* chunks, grouping chunks from the same library, @@ -808,6 +815,7 @@ PSec->Chunks.push_back(C); } + fixPartialSectionChars(".rsrc", DATA | R); // Even in non MinGW cases, we might need to link against GNU import // libraries. bool HasIdata = fixGnuImportChunks(); Index: test/COFF/resource-objs.test =================================================================== --- /dev/null +++ test/COFF/resource-objs.test @@ -0,0 +1,5 @@ +# RUN: lld-link /out:%t.exe /dll /noentry %S/Inputs/id.res.obj +# RUN: llvm-readobj -file-headers %t.exe | FileCheck %s + +CHECK: ResourceTableRVA: 0x1000 +CHECK: ResourceTableSize: 0x80