diff --git a/clang-tools-extra/clangd/index/dex/PostingList.cpp b/clang-tools-extra/clangd/index/dex/PostingList.cpp --- a/clang-tools-extra/clangd/index/dex/PostingList.cpp +++ b/clang-tools-extra/clangd/index/dex/PostingList.cpp @@ -50,8 +50,8 @@ return; advanceToChunk(ID); // Try to find ID within current chunk. - CurrentID = llvm::bsearch(CurrentID, DecompressedChunk.end(), - [&](const DocID D) { return D >= ID; }); + CurrentID = std::partition_point(CurrentID, DecompressedChunk.end(), + [&](const DocID D) { return D < ID; }); normalizeCursor(); } @@ -103,8 +103,8 @@ if ((CurrentChunk != Chunks.end() - 1) && ((CurrentChunk + 1)->Head <= ID)) { CurrentChunk = - llvm::bsearch(CurrentChunk + 1, Chunks.end(), - [&](const Chunk &C) { return C.Head >= ID; }); + std::partition_point(CurrentChunk + 1, Chunks.end(), + [&](const Chunk &C) { return C.Head < ID; }); --CurrentChunk; DecompressedChunk = CurrentChunk->decompress(); CurrentID = DecompressedChunk.begin(); diff --git a/llvm/include/llvm/ADT/STLExtras.h b/llvm/include/llvm/ADT/STLExtras.h --- a/llvm/include/llvm/ADT/STLExtras.h +++ b/llvm/include/llvm/ADT/STLExtras.h @@ -1322,44 +1322,22 @@ std::stable_sort(adl_begin(Range), adl_end(Range), C); } -/// Binary search for the first index where a predicate is true. -/// Returns the first I in [Lo, Hi) where C(I) is true, or Hi if it never is. -/// Requires that C is always false below some limit, and always true above it. -/// -/// Example: -/// size_t DawnModernEra = bsearch(1776, 2050, [](size_t Year){ -/// return Presidents.for(Year).twitterHandle() != None; -/// }); -/// -/// Note the return value differs from std::binary_search! -template -size_t bsearch(size_t Lo, size_t Hi, Predicate P) { - while (Lo != Hi) { - assert(Hi > Lo); - size_t Mid = Lo + (Hi - Lo) / 2; - if (P(Mid)) - Hi = Mid; - else - Lo = Mid + 1; - } - return Hi; -} - +/// \deprecated Use std::partition_point. /// Binary search for the first iterator where a predicate is true. /// Returns the first I in [Lo, Hi) where C(*I) is true, or Hi if it never is. /// Requires that C is always false below some limit, and always true above it. template ())> It bsearch(It Lo, It Hi, Predicate P) { - return std::lower_bound(Lo, Hi, 0u, - [&](const Val &V, unsigned) { return !P(V); }); + return std::partition_point(Lo, Hi, [&](const Val &V) { return !P(V); }); } /// Binary search for the first iterator in a range where a predicate is true. /// Requires that C is always false below some limit, and always true above it. template auto bsearch(R &&Range, Predicate P) -> decltype(adl_begin(Range)) { - return bsearch(adl_begin(Range), adl_end(Range), P); + return llvm::bsearch(adl_begin(Range), adl_end(Range), + std::forward(P)); } /// Wrapper function around std::equal to detect if all elements diff --git a/llvm/include/llvm/CodeGen/SlotIndexes.h b/llvm/include/llvm/CodeGen/SlotIndexes.h --- a/llvm/include/llvm/CodeGen/SlotIndexes.h +++ b/llvm/include/llvm/CodeGen/SlotIndexes.h @@ -492,8 +492,9 @@ /// Move iterator to the next IdxMBBPair where the SlotIndex is greater or /// equal to \p To. MBBIndexIterator advanceMBBIndex(MBBIndexIterator I, SlotIndex To) const { - return llvm::bsearch(I, idx2MBBMap.end(), - [=](const IdxMBBPair &IM) { return To <= IM.first; }); + return std::partition_point( + I, idx2MBBMap.end(), + [=](const IdxMBBPair &IM) { return IM.first < To; }); } /// Get an iterator pointing to the IdxMBBPair with the biggest SlotIndex diff --git a/llvm/unittests/ADT/STLExtrasTest.cpp b/llvm/unittests/ADT/STLExtrasTest.cpp --- a/llvm/unittests/ADT/STLExtrasTest.cpp +++ b/llvm/unittests/ADT/STLExtrasTest.cpp @@ -470,11 +470,6 @@ } TEST(STLExtrasTest, bsearch) { - // Integer version. - EXPECT_EQ(7u, bsearch(5, 10, [](unsigned X) { return X >= 7; })); - EXPECT_EQ(5u, bsearch(5, 10, [](unsigned X) { return X >= 1; })); - EXPECT_EQ(10u, bsearch(5, 10, [](unsigned X) { return X >= 50; })); - // Iterator version. std::vector V = {1, 3, 5, 7, 9}; EXPECT_EQ(V.begin() + 3,