diff --git a/clang/include/clang/AST/Mangle.h b/clang/include/clang/AST/Mangle.h --- a/clang/include/clang/AST/Mangle.h +++ b/clang/include/clang/AST/Mangle.h @@ -17,7 +17,6 @@ #include "clang/AST/Type.h" #include "clang/Basic/ABI.h" #include "llvm/ADT/DenseMap.h" -#include "llvm/IR/DataLayout.h" #include "llvm/Support/Casting.h" namespace llvm { @@ -246,21 +245,16 @@ }; class ASTNameGenerator { - std::unique_ptr MC; - llvm::DataLayout DL; - public: explicit ASTNameGenerator(ASTContext &Ctx); + ~ASTNameGenerator(); bool writeName(const Decl *D, raw_ostream &OS); std::string getName(const Decl *D); std::vector getAllManglings(const Decl *D); private: - std::vector getAllManglings(const ObjCContainerDecl *OCD); - bool writeFuncOrVarName(const NamedDecl *D, raw_ostream &OS); - void writeObjCClassName(const ObjCInterfaceDecl *D, raw_ostream &OS); - std::string getMangledStructor(const NamedDecl *ND, unsigned StructorType); - std::string getMangledThunk(const CXXMethodDecl *MD, const ThunkInfo &T); + class Implementation; + std::unique_ptr Impl; }; } diff --git a/clang/lib/AST/Mangle.cpp b/clang/lib/AST/Mangle.cpp --- a/clang/lib/AST/Mangle.cpp +++ b/clang/lib/AST/Mangle.cpp @@ -22,6 +22,7 @@ #include "clang/Basic/SourceManager.h" #include "clang/Basic/TargetInfo.h" #include "llvm/ADT/StringExtras.h" +#include "llvm/IR/DataLayout.h" #include "llvm/IR/Mangler.h" #include "llvm/Support/ErrorHandling.h" #include "llvm/Support/raw_ostream.h" @@ -283,183 +284,204 @@ Out << OS.str().size() << OS.str(); } -ASTNameGenerator::ASTNameGenerator(ASTContext &Ctx) - : MC(Ctx.createMangleContext()), DL(Ctx.getTargetInfo().getDataLayout()) {} +class ASTNameGenerator::Implementation { + std::unique_ptr MC; + llvm::DataLayout DL; -bool ASTNameGenerator::writeName(const Decl *D, raw_ostream &OS) { - // First apply frontend mangling. - SmallString<128> FrontendBuf; - llvm::raw_svector_ostream FrontendBufOS(FrontendBuf); - if (auto *FD = dyn_cast(D)) { - if (FD->isDependentContext()) - return true; - if (writeFuncOrVarName(FD, FrontendBufOS)) - return true; - } else if (auto *VD = dyn_cast(D)) { - if (writeFuncOrVarName(VD, FrontendBufOS)) +public: + explicit Implementation(ASTContext &Ctx) + : MC(Ctx.createMangleContext()), DL(Ctx.getTargetInfo().getDataLayout()) { + } + + bool writeName(const Decl *D, raw_ostream &OS) { + // First apply frontend mangling. + SmallString<128> FrontendBuf; + llvm::raw_svector_ostream FrontendBufOS(FrontendBuf); + if (auto *FD = dyn_cast(D)) { + if (FD->isDependentContext()) + return true; + if (writeFuncOrVarName(FD, FrontendBufOS)) + return true; + } else if (auto *VD = dyn_cast(D)) { + if (writeFuncOrVarName(VD, FrontendBufOS)) + return true; + } else if (auto *MD = dyn_cast(D)) { + MC->mangleObjCMethodNameWithoutSize(MD, OS); + return false; + } else if (auto *ID = dyn_cast(D)) { + writeObjCClassName(ID, FrontendBufOS); + } else { return true; - } else if (auto *MD = dyn_cast(D)) { - MC->mangleObjCMethodNameWithoutSize(MD, OS); + } + + // Now apply backend mangling. + llvm::Mangler::getNameWithPrefix(OS, FrontendBufOS.str(), DL); return false; - } else if (auto *ID = dyn_cast(D)) { - writeObjCClassName(ID, FrontendBufOS); - } else { - return true; } - // Now apply backend mangling. - llvm::Mangler::getNameWithPrefix(OS, FrontendBufOS.str(), DL); - return false; -} - -std::string ASTNameGenerator::getName(const Decl *D) { - std::string Name; - { - llvm::raw_string_ostream OS(Name); - writeName(D, OS); + std::string getName(const Decl *D) { + std::string Name; + { + llvm::raw_string_ostream OS(Name); + writeName(D, OS); + } + return Name; } - return Name; -} -enum ObjCKind { - ObjCClass, - ObjCMetaclass, -}; + enum ObjCKind { + ObjCClass, + ObjCMetaclass, + }; -static StringRef getClassSymbolPrefix(ObjCKind Kind, - const ASTContext &Context) { - if (Context.getLangOpts().ObjCRuntime.isGNUFamily()) - return Kind == ObjCMetaclass ? "_OBJC_METACLASS_" : "_OBJC_CLASS_"; - return Kind == ObjCMetaclass ? "OBJC_METACLASS_$_" : "OBJC_CLASS_$_"; -} + static StringRef getClassSymbolPrefix(ObjCKind Kind, + const ASTContext &Context) { + if (Context.getLangOpts().ObjCRuntime.isGNUFamily()) + return Kind == ObjCMetaclass ? "_OBJC_METACLASS_" : "_OBJC_CLASS_"; + return Kind == ObjCMetaclass ? "OBJC_METACLASS_$_" : "OBJC_CLASS_$_"; + } -std::vector -ASTNameGenerator::getAllManglings(const ObjCContainerDecl *OCD) { - StringRef ClassName; - if (const auto *OID = dyn_cast(OCD)) - ClassName = OID->getObjCRuntimeNameAsString(); - else if (const auto *OID = dyn_cast(OCD)) - ClassName = OID->getObjCRuntimeNameAsString(); - - if (ClassName.empty()) - return {}; - - auto Mangle = [&](ObjCKind Kind, StringRef ClassName) -> std::string { - SmallString<40> Mangled; - auto Prefix = getClassSymbolPrefix(Kind, OCD->getASTContext()); - llvm::Mangler::getNameWithPrefix(Mangled, Prefix + ClassName, DL); - return Mangled.str(); - }; + std::vector getAllManglings(const ObjCContainerDecl *OCD) { + StringRef ClassName; + if (const auto *OID = dyn_cast(OCD)) + ClassName = OID->getObjCRuntimeNameAsString(); + else if (const auto *OID = dyn_cast(OCD)) + ClassName = OID->getObjCRuntimeNameAsString(); + + if (ClassName.empty()) + return {}; + + auto Mangle = [&](ObjCKind Kind, StringRef ClassName) -> std::string { + SmallString<40> Mangled; + auto Prefix = getClassSymbolPrefix(Kind, OCD->getASTContext()); + llvm::Mangler::getNameWithPrefix(Mangled, Prefix + ClassName, DL); + return Mangled.str(); + }; + + return { + Mangle(ObjCClass, ClassName), + Mangle(ObjCMetaclass, ClassName), + }; + } - return { - Mangle(ObjCClass, ClassName), - Mangle(ObjCMetaclass, ClassName), - }; -} + std::vector getAllManglings(const Decl *D) { + if (const auto *OCD = dyn_cast(D)) + return getAllManglings(OCD); -std::vector ASTNameGenerator::getAllManglings(const Decl *D) { - if (const auto *OCD = dyn_cast(D)) - return getAllManglings(OCD); + if (!(isa(D) || isa(D))) + return {}; - if (!(isa(D) || isa(D))) - return {}; + const NamedDecl *ND = cast(D); - const NamedDecl *ND = cast(D); + ASTContext &Ctx = ND->getASTContext(); + std::unique_ptr M(Ctx.createMangleContext()); - ASTContext &Ctx = ND->getASTContext(); - std::unique_ptr M(Ctx.createMangleContext()); + std::vector Manglings; - std::vector Manglings; + auto hasDefaultCXXMethodCC = [](ASTContext &C, const CXXMethodDecl *MD) { + auto DefaultCC = C.getDefaultCallingConvention(/*IsVariadic=*/false, + /*IsCSSMethod=*/true); + auto CC = MD->getType()->getAs()->getCallConv(); + return CC == DefaultCC; + }; - auto hasDefaultCXXMethodCC = [](ASTContext &C, const CXXMethodDecl *MD) { - auto DefaultCC = C.getDefaultCallingConvention(/*IsVariadic=*/false, - /*IsCSSMethod=*/true); - auto CC = MD->getType()->getAs()->getCallConv(); - return CC == DefaultCC; - }; + if (const auto *CD = dyn_cast_or_null(ND)) { + Manglings.emplace_back(getMangledStructor(CD, Ctor_Base)); + + if (Ctx.getTargetInfo().getCXXABI().isItaniumFamily()) + if (!CD->getParent()->isAbstract()) + Manglings.emplace_back(getMangledStructor(CD, Ctor_Complete)); - if (const auto *CD = dyn_cast_or_null(ND)) { - Manglings.emplace_back(getMangledStructor(CD, Ctor_Base)); - - if (Ctx.getTargetInfo().getCXXABI().isItaniumFamily()) - if (!CD->getParent()->isAbstract()) - Manglings.emplace_back(getMangledStructor(CD, Ctor_Complete)); - - if (Ctx.getTargetInfo().getCXXABI().isMicrosoft()) - if (CD->hasAttr() && CD->isDefaultConstructor()) - if (!(hasDefaultCXXMethodCC(Ctx, CD) && CD->getNumParams() == 0)) - Manglings.emplace_back(getMangledStructor(CD, Ctor_DefaultClosure)); - } else if (const auto *DD = dyn_cast_or_null(ND)) { - Manglings.emplace_back(getMangledStructor(DD, Dtor_Base)); - if (Ctx.getTargetInfo().getCXXABI().isItaniumFamily()) { - Manglings.emplace_back(getMangledStructor(DD, Dtor_Complete)); - if (DD->isVirtual()) - Manglings.emplace_back(getMangledStructor(DD, Dtor_Deleting)); + if (Ctx.getTargetInfo().getCXXABI().isMicrosoft()) + if (CD->hasAttr() && CD->isDefaultConstructor()) + if (!(hasDefaultCXXMethodCC(Ctx, CD) && CD->getNumParams() == 0)) + Manglings.emplace_back(getMangledStructor(CD, Ctor_DefaultClosure)); + } else if (const auto *DD = dyn_cast_or_null(ND)) { + Manglings.emplace_back(getMangledStructor(DD, Dtor_Base)); + if (Ctx.getTargetInfo().getCXXABI().isItaniumFamily()) { + Manglings.emplace_back(getMangledStructor(DD, Dtor_Complete)); + if (DD->isVirtual()) + Manglings.emplace_back(getMangledStructor(DD, Dtor_Deleting)); + } + } else if (const auto *MD = dyn_cast_or_null(ND)) { + Manglings.emplace_back(getName(ND)); + if (MD->isVirtual()) + if (const auto *TIV = Ctx.getVTableContext()->getThunkInfo(MD)) + for (const auto &T : *TIV) + Manglings.emplace_back(getMangledThunk(MD, T)); } - } else if (const auto *MD = dyn_cast_or_null(ND)) { - Manglings.emplace_back(getName(ND)); - if (MD->isVirtual()) - if (const auto *TIV = Ctx.getVTableContext()->getThunkInfo(MD)) - for (const auto &T : *TIV) - Manglings.emplace_back(getMangledThunk(MD, T)); + + return Manglings; } - return Manglings; -} +private: + bool writeFuncOrVarName(const NamedDecl *D, raw_ostream &OS) { + if (MC->shouldMangleDeclName(D)) { + if (const auto *CtorD = dyn_cast(D)) + MC->mangleCXXCtor(CtorD, Ctor_Complete, OS); + else if (const auto *DtorD = dyn_cast(D)) + MC->mangleCXXDtor(DtorD, Dtor_Complete, OS); + else + MC->mangleName(D, OS); + return false; + } else { + IdentifierInfo *II = D->getIdentifier(); + if (!II) + return true; + OS << II->getName(); + return false; + } + } -bool ASTNameGenerator::writeFuncOrVarName(const NamedDecl *D, raw_ostream &OS) { - if (MC->shouldMangleDeclName(D)) { - if (const auto *CtorD = dyn_cast(D)) - MC->mangleCXXCtor(CtorD, Ctor_Complete, OS); - else if (const auto *DtorD = dyn_cast(D)) - MC->mangleCXXDtor(DtorD, Dtor_Complete, OS); - else - MC->mangleName(D, OS); - return false; - } else { - IdentifierInfo *II = D->getIdentifier(); - if (!II) - return true; - OS << II->getName(); - return false; + void writeObjCClassName(const ObjCInterfaceDecl *D, raw_ostream &OS) { + OS << getClassSymbolPrefix(ObjCClass, D->getASTContext()); + OS << D->getObjCRuntimeNameAsString(); } -} -void ASTNameGenerator::writeObjCClassName(const ObjCInterfaceDecl *D, - raw_ostream &OS) { - OS << getClassSymbolPrefix(ObjCClass, D->getASTContext()); - OS << D->getObjCRuntimeNameAsString(); -} + std::string getMangledStructor(const NamedDecl *ND, unsigned StructorType) { + std::string FrontendBuf; + llvm::raw_string_ostream FOS(FrontendBuf); + + if (const auto *CD = dyn_cast_or_null(ND)) + MC->mangleCXXCtor(CD, static_cast(StructorType), FOS); + else if (const auto *DD = dyn_cast_or_null(ND)) + MC->mangleCXXDtor(DD, static_cast(StructorType), FOS); -std::string ASTNameGenerator::getMangledStructor(const NamedDecl *ND, - unsigned StructorType) { - std::string FrontendBuf; - llvm::raw_string_ostream FOS(FrontendBuf); + std::string BackendBuf; + llvm::raw_string_ostream BOS(BackendBuf); - if (const auto *CD = dyn_cast_or_null(ND)) - MC->mangleCXXCtor(CD, static_cast(StructorType), FOS); - else if (const auto *DD = dyn_cast_or_null(ND)) - MC->mangleCXXDtor(DD, static_cast(StructorType), FOS); + llvm::Mangler::getNameWithPrefix(BOS, FOS.str(), DL); - std::string BackendBuf; - llvm::raw_string_ostream BOS(BackendBuf); + return BOS.str(); + } - llvm::Mangler::getNameWithPrefix(BOS, FOS.str(), DL); + std::string getMangledThunk(const CXXMethodDecl *MD, const ThunkInfo &T) { + std::string FrontendBuf; + llvm::raw_string_ostream FOS(FrontendBuf); - return BOS.str(); -} + MC->mangleThunk(MD, T, FOS); -std::string ASTNameGenerator::getMangledThunk(const CXXMethodDecl *MD, - const ThunkInfo &T) { - std::string FrontendBuf; - llvm::raw_string_ostream FOS(FrontendBuf); + std::string BackendBuf; + llvm::raw_string_ostream BOS(BackendBuf); - MC->mangleThunk(MD, T, FOS); + llvm::Mangler::getNameWithPrefix(BOS, FOS.str(), DL); - std::string BackendBuf; - llvm::raw_string_ostream BOS(BackendBuf); + return BOS.str(); + } +}; - llvm::Mangler::getNameWithPrefix(BOS, FOS.str(), DL); +ASTNameGenerator::ASTNameGenerator(ASTContext &Ctx) + : Impl(new Implementation(Ctx)) {} + +ASTNameGenerator::~ASTNameGenerator() {} - return BOS.str(); +bool ASTNameGenerator::writeName(const Decl *D, raw_ostream &OS) { + return Impl->writeName(D, OS); +} + +std::string ASTNameGenerator::getName(const Decl *D) { + return Impl->getName(D); +} + +std::vector ASTNameGenerator::getAllManglings(const Decl *D) { + return Impl->getAllManglings(D); }