diff --git a/clang/lib/CodeGen/CodeGenAction.cpp b/clang/lib/CodeGen/CodeGenAction.cpp --- a/clang/lib/CodeGen/CodeGenAction.cpp +++ b/clang/lib/CodeGen/CodeGenAction.cpp @@ -37,6 +37,7 @@ #include "llvm/Pass.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/SourceMgr.h" +#include "llvm/Support/TimeProfiler.h" #include "llvm/Support/Timer.h" #include "llvm/Support/ToolOutputFile.h" #include "llvm/Support/YAMLTraits.h" @@ -246,6 +247,12 @@ IRGenFinished = true; } + // Finish "Frontend" section starting inside clang::ParseAST() + // We don't want "Backend" section to turn out within "Frontend" section, + // so finishing it here before EmitBackendOutput() and possible return's. + if (llvm::timeTraceProfilerEnabled()) + llvm::timeTraceProfilerEnd(); + // Silently ignore if we weren't initialized for some reason. if (!getModule()) return; diff --git a/clang/lib/Parse/ParseAST.cpp b/clang/lib/Parse/ParseAST.cpp --- a/clang/lib/Parse/ParseAST.cpp +++ b/clang/lib/Parse/ParseAST.cpp @@ -150,8 +150,12 @@ // after the pragma, there won't be any tokens or a Lexer. bool HaveLexer = S.getPreprocessor().getCurrentLexer(); + // Start "Frontend" section finishing inside clang::HandleTranslationUnit() + if (llvm::timeTraceProfilerEnabled()) + llvm::timeTraceProfilerBegin("Frontend", StringRef("")); + if (HaveLexer) { - llvm::TimeTraceScope TimeScope("Frontend", StringRef("")); + llvm::TimeTraceScope TimeScope("Lexing", StringRef("")); P.Initialize(); Parser::DeclGroupPtrTy ADecl; for (bool AtEOF = P.ParseFirstTopLevelDecl(ADecl); !AtEOF; diff --git a/clang/test/Driver/check-time-trace-sections.cpp b/clang/test/Driver/check-time-trace-sections.cpp new file mode 100644 --- /dev/null +++ b/clang/test/Driver/check-time-trace-sections.cpp @@ -0,0 +1,7 @@ +// REQUIRES: shell +// RUN: %clangxx -S -ftime-trace -mllvm --time-trace-granularity=0 -o %T/check-time-trace-sections %s +// RUN: cat %T/check-time-trace-sections.json | %python %S/check-time-trace-sections.py + +template +void foo(T) {} +void bar() { foo(0); } diff --git a/clang/test/Driver/check-time-trace-sections.py b/clang/test/Driver/check-time-trace-sections.py new file mode 100644 --- /dev/null +++ b/clang/test/Driver/check-time-trace-sections.py @@ -0,0 +1,20 @@ +#!/usr/bin/env python + +import json, sys + +def is_inside(range1, range2): + a = range1["ts"]; b = a + range1["dur"] + c = range2["ts"]; d = c + range2["dur"] + return (a >= c and a <= d) and (b >= c and b <= d) + +events = json.loads(sys.stdin.read())["traceEvents"] +codegens = filter(lambda x: x["name"] == "CodeGen Function", events) +frontends = filter(lambda x: x["name"] == "Frontend", events) + +if not len(frontends) == 1: + sys.exit("There should be exactly one Frontend section!") + +frontend = frontends[0] + +if not all([is_inside(codegen, frontend) for codegen in codegens]): + sys.exit("Not all CodeGen sections are inside Frontend section!") diff --git a/llvm/lib/Support/TimeProfiler.cpp b/llvm/lib/Support/TimeProfiler.cpp --- a/llvm/lib/Support/TimeProfiler.cpp +++ b/llvm/lib/Support/TimeProfiler.cpp @@ -65,7 +65,7 @@ E.Duration = steady_clock::now() - E.Start; // Only include sections longer than TimeTraceGranularity msec. - if (duration_cast(E.Duration).count() > TimeTraceGranularity) + if (duration_cast(E.Duration).count() >= TimeTraceGranularity) Entries.emplace_back(E); // Track total time taken by each "name", but only the topmost levels of