This is an archive of the discontinued LLVM Phabricator instance.

Differential D63289

[libc++] Add missing #include in tests
ClosedPublic

Authored by miyuki on Jun 13 2019, 10:45 AM.

Details

Reviewers
ldionne
mclow.lists
EricWF
Commits
rCXX363290: [libc++] Add missing #include in <cwchar> tests
rG64c1d456c1b2: [libc++] Add missing #include in <cwchar> tests
rL363290: [libc++] Add missing #include in <cwchar> tests
Summary

The tests that use 'FILE' must include <stdio.h> or <cstdio>,
otherwise they will fail on some platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

miyuki created this revision.Jun 13 2019, 10:45 AM
Herald added a reviewer: EricWF. · View Herald TranscriptJun 13 2019, 10:45 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: dexonsmith, christof. · View Herald Transcript
ldionne accepted this revision.Jun 13 2019, 11:01 AM
This revision is now accepted and ready to land.Jun 13 2019, 11:01 AM
Closed by commit rL363290: [libc++] Add missing #include in <cwchar> tests (authored by ldionne). · Explain WhyJun 13 2019, 11:21 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 11:21 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
libcxx/
trunk/
test/
std/
depr/
depr.c.headers/
1 line
strings/
c.strings/
1 line

Diff 204592

libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// <wchar.h> // <wchar.h>
#include <wchar.h> #include <wchar.h>
#include <stdarg.h> #include <stdarg.h>
#include <stdio.h>
#include <type_traits> #include <type_traits>
#include "test_macros.h" #include "test_macros.h"
#ifndef NULL #ifndef NULL
#error NULL not defined #error NULL not defined
#endif #endif
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines

libcxx/trunk/test/std/strings/c.strings/cwchar.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// <cwchar> // <cwchar>
#include <cwchar> #include <cwchar>
#include <ctime> #include <ctime>
#include <cstdarg> #include <cstdarg>
#include <cstdio>
#include <type_traits> #include <type_traits>
#include "test_macros.h" #include "test_macros.h"
#ifndef NULL #ifndef NULL
#error NULL not defined #error NULL not defined
#endif #endif
▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines