Index: test/tools/llvm-readobj/elf-wrong-shstrtab-type.test =================================================================== --- /dev/null +++ test/tools/llvm-readobj/elf-wrong-shstrtab-type.test @@ -0,0 +1,11 @@ +## wrong-shstrtab-type.elf-x86-64 contains .shstrtab section which has SHT_PROGBITS type. +## Check we do not fail to dump the section headers in this case. + +# RUN: llvm-readobj -S %p/Inputs/wrong-shstrtab-type.elf-x86-64 | FileCheck %s --check-prefix LLVM +# RUN: llvm-readelf -S %p/Inputs/wrong-shstrtab-type.elf-x86-64 | FileCheck %s --check-prefix GNU + +# LLVM: Name: .shstrtab +# LLVM-NEXT: Type: SHT_PROGBITS + +# GNU: [Nr] Name Type +# GNU: [ 3] .shstrtab PROGBITS Index: tools/llvm-readobj/ELFDumper.cpp =================================================================== --- tools/llvm-readobj/ELFDumper.cpp +++ tools/llvm-readobj/ELFDumper.cpp @@ -3003,6 +3003,22 @@ return ""; } +template +static StringRef getSectionName(const typename ELFT::Shdr &Sec, + const ELFFile &Obj, + ArrayRef Sections) { + uint32_t Index = Obj.getHeader()->e_shstrndx; + if (Index == ELF::SHN_XINDEX) + Index = Sections[0].sh_link; + if (!Index) // no section string table. + return ""; + if (Index >= Sections.size()) + reportError("invalid section index"); + StringRef Data = toStringRef(unwrapOrError( + Obj.template getSectionContentsAsArray(&Sections[Index]))); + return unwrapOrError(Obj.getSectionName(&Sec, Data)); +} + template void GNUStyle::printSectionHeaders(const ELFO *Obj) { unsigned Bias = ELFT::Is64Bits ? 0 : 8; @@ -3023,7 +3039,7 @@ size_t SectionIndex = 0; for (const Elf_Shdr &Sec : Sections) { Fields[0].Str = to_string(SectionIndex); - Fields[1].Str = unwrapOrError(Obj->getSectionName(&Sec)); + Fields[1].Str = getSectionName(Sec, *Obj, Sections); Fields[2].Str = getSectionTypeString(Obj->getHeader()->e_machine, Sec.sh_type); Fields[3].Str = @@ -4569,13 +4585,11 @@ ListScope SectionsD(W, "Sections"); int SectionIndex = -1; - for (const Elf_Shdr &Sec : unwrapOrError(Obj->sections())) { - ++SectionIndex; - - StringRef Name = unwrapOrError(Obj->getSectionName(&Sec)); - + ArrayRef Sections = unwrapOrError(Obj->sections()); + for (const Elf_Shdr &Sec : Sections) { + StringRef Name = getSectionName(Sec, *Obj, Sections); DictScope SectionD(W, "Section"); - W.printNumber("Index", SectionIndex); + W.printNumber("Index", ++SectionIndex); W.printNumber("Name", Name, Sec.sh_name); W.printHex( "Type",