Fixes the checker for abseil to make tests pass in C++17 mode
Thanks for investigating these, nice work!
Some initial comments:
- since your patch fixes four different check, I'd suggest to separate it (one patch per check)
- there are some non-functional changes (code format), I'd avoid them in this patch (we could address them in a separate patch)
- it would be nice if you could briefly describe the AST difference between C++11 and C++17 (how the fix work) in the patch description or comments
I believe the tests are also passed for C++2a? use C++11-or-later will do the trick.
hasDescendant will find any child, no matter how deeply nested. I think in this case we only want the expression itself to be equal to ByAnyChar call. Shouldn't this code use the elidable matcher you're adding in another file?
Ditto, hasAncestor can go too far up the tree.