Index: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp =================================================================== --- llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -6601,6 +6601,16 @@ return DAG.getNode(NewOpcode, DL, VT, LHS, RHS); } } + + // fold (not (neg x)) -> (add X, -1) + // FIXME: This can be generalized to (not (sub Y, X)) -> (add X, ~Y) if + // Y is a constant or the subtract has a single use. + if (isAllOnesConstant(N1) && N0.getOpcode() == ISD::SUB && + isNullConstant(N0.getOperand(0))) { + return DAG.getNode(ISD::ADD, DL, VT, N0.getOperand(1), + DAG.getAllOnesConstant(DL, VT)); + } + // fold (xor (and x, y), y) -> (and (not x), y) if (N0Opcode == ISD::AND && N0.hasOneUse() && N0->getOperand(1) == N1) { SDValue X = N0.getOperand(0); Index: llvm/test/CodeGen/X86/bmi.ll =================================================================== --- llvm/test/CodeGen/X86/bmi.ll +++ llvm/test/CodeGen/X86/bmi.ll @@ -1153,10 +1153,7 @@ define void @pr42118_i32(i32 %x) { ; X86-LABEL: pr42118_i32: ; X86: # %bb.0: -; X86-NEXT: movl {{[0-9]+}}(%esp), %eax -; X86-NEXT: movl %eax, %ecx -; X86-NEXT: negl %ecx -; X86-NEXT: andnl %eax, %ecx, %eax +; X86-NEXT: blsrl {{[0-9]+}}(%esp), %eax ; X86-NEXT: jne .LBB48_1 ; X86-NEXT: # %bb.2: ; X86-NEXT: jmp bar # TAILCALL @@ -1165,9 +1162,7 @@ ; ; X64-LABEL: pr42118_i32: ; X64: # %bb.0: -; X64-NEXT: movl %edi, %eax -; X64-NEXT: negl %eax -; X64-NEXT: andnl %edi, %eax, %eax +; X64-NEXT: blsrl %edi, %eax ; X64-NEXT: jne .LBB48_1 ; X64-NEXT: # %bb.2: ; X64-NEXT: jmp bar # TAILCALL @@ -1192,13 +1187,13 @@ ; X86-NEXT: .cfi_offset %esi, -8 ; X86-NEXT: movl {{[0-9]+}}(%esp), %eax ; X86-NEXT: movl {{[0-9]+}}(%esp), %ecx -; X86-NEXT: xorl %edx, %edx -; X86-NEXT: movl %eax, %esi -; X86-NEXT: negl %esi -; X86-NEXT: sbbl %ecx, %edx -; X86-NEXT: andnl %ecx, %edx, %ecx -; X86-NEXT: andnl %eax, %esi, %eax -; X86-NEXT: orl %ecx, %eax +; X86-NEXT: movl %eax, %edx +; X86-NEXT: addl $-1, %edx +; X86-NEXT: movl %ecx, %esi +; X86-NEXT: adcl $-1, %esi +; X86-NEXT: andl %eax, %edx +; X86-NEXT: andl %ecx, %esi +; X86-NEXT: orl %edx, %esi ; X86-NEXT: jne .LBB49_1 ; X86-NEXT: # %bb.2: ; X86-NEXT: popl %esi @@ -1212,9 +1207,7 @@ ; ; X64-LABEL: pr42118_i64: ; X64: # %bb.0: -; X64-NEXT: movq %rdi, %rax -; X64-NEXT: negq %rax -; X64-NEXT: andnq %rdi, %rax, %rax +; X64-NEXT: blsrq %rdi, %rax ; X64-NEXT: jne .LBB49_1 ; X64-NEXT: # %bb.2: ; X64-NEXT: jmp bar # TAILCALL