Index: cfe/trunk/include/clang/AST/Expr.h =================================================================== --- cfe/trunk/include/clang/AST/Expr.h +++ cfe/trunk/include/clang/AST/Expr.h @@ -490,6 +490,15 @@ return false; } + /// Returns whether this expression has a placeholder type that isn't + /// Overload. + bool hasNonOverloadPlaceholderType() const { + if (auto *PlaceholderType = getType()->getAsPlaceholderType()) + if (PlaceholderType->isNonOverloadPlaceholderType()) + return true; + return false; + } + /// isKnownToHaveBooleanValue - Return true if this is an integer expression /// that is known to return 0 or 1. This happens for _Bool/bool expressions /// but also int expressions which are produced by things like comparisons in Index: cfe/trunk/include/clang/Basic/Attr.td =================================================================== --- cfe/trunk/include/clang/Basic/Attr.td +++ cfe/trunk/include/clang/Basic/Attr.td @@ -1844,6 +1844,16 @@ let Documentation = [ObjCBoxableDocs]; } + +// This is used to indicate that the type of the annotated variable's +// initializer was changed from UnknownAny to 'id'. +def ObjCDefaultedAnyToId : Attr { + // This attribute has no spellings as it is only ever created implicitly. + let Spellings = []; + let Subjects = SubjectList<[Var]>; + let Documentation = [Undocumented]; +} + def OptimizeNone : InheritableAttr { let Spellings = [Clang<"optnone">]; let Subjects = SubjectList<[Function, ObjCMethod]>; Index: cfe/trunk/lib/Sema/SemaDecl.cpp =================================================================== --- cfe/trunk/lib/Sema/SemaDecl.cpp +++ cfe/trunk/lib/Sema/SemaDecl.cpp @@ -10985,18 +10985,6 @@ return QualType(); } - // Expressions default to 'id' when we're in a debugger. - bool DefaultedAnyToId = false; - if (getLangOpts().DebuggerCastResultToId && - Init->getType() == Context.UnknownAnyTy && !IsInitCapture) { - ExprResult Result = forceUnknownAnyToType(Init, Context.getObjCIdType()); - if (Result.isInvalid()) { - return QualType(); - } - Init = Result.get(); - DefaultedAnyToId = true; - } - // C++ [dcl.decomp]p1: // If the assignment-expression [...] has array type A and no ref-qualifier // is present, e has type cv A @@ -11030,6 +11018,7 @@ // checks. // We only want to warn outside of template instantiations, though: // inside a template, the 'id' could have come from a parameter. + bool DefaultedAnyToId = VDecl && VDecl->hasAttr(); if (!inTemplateInstantiation() && !DefaultedAnyToId && !IsInitCapture && !DeducedType.isNull() && DeducedType->isObjCIdType()) { SourceLocation Loc = TSI->getTypeLoc().getBeginLoc(); @@ -11108,6 +11097,27 @@ } Init = Res.get(); + // Expressions default to 'id' when we're in a debugger + // and we are assigning it to a variable of Objective-C pointer type. + if (getLangOpts().DebuggerCastResultToId && + Init->getType() == Context.UnknownAnyTy) { + ExprResult Result = forceUnknownAnyToType(Init, Context.getObjCIdType()); + if (Result.isInvalid()) { + VDecl->setInvalidDecl(); + return; + } + Init = Result.get(); + VDecl->addAttr(ObjCDefaultedAnyToIdAttr::CreateImplicit(Context)); + } else if (!Init->getType().isNull() && + Init->hasNonOverloadPlaceholderType()) { + Res = CheckPlaceholderExpr(Init).get(); + if (!Res.isUsable()) { + VDecl->setInvalidDecl(); + return; + } + Init = Res.get(); + } + if (DeduceVariableDeclarationType(VDecl, DirectInit, Init)) return; } Index: cfe/trunk/lib/Sema/SemaExpr.cpp =================================================================== --- cfe/trunk/lib/Sema/SemaExpr.cpp +++ cfe/trunk/lib/Sema/SemaExpr.cpp @@ -6678,6 +6678,14 @@ ExprResult Sema::ActOnParenListExpr(SourceLocation L, SourceLocation R, MultiExprArg Val) { + for (size_t I = 0, E = Val.size(); I != E; ++I) + if (Val[I]->hasNonOverloadPlaceholderType()) { + ExprResult Result = CheckPlaceholderExpr(Val[I]); + if (!Result.isUsable()) + return ExprError(); + Val[I] = Result.get(); + } + return ParenListExpr::Create(Context, L, Val, R); } Index: cfe/trunk/lib/Sema/SemaExprCXX.cpp =================================================================== --- cfe/trunk/lib/Sema/SemaExprCXX.cpp +++ cfe/trunk/lib/Sema/SemaExprCXX.cpp @@ -1793,6 +1793,14 @@ NumInits = List->getNumExprs(); } + for (unsigned I = 0, E = NumInits; I != E; ++I) + if (Inits[I]->hasNonOverloadPlaceholderType()) { + ExprResult Result = CheckPlaceholderExpr(Inits[I]); + if (!Result.isUsable()) + return ExprError(); + Inits[I] = Result.get(); + } + // C++11 [expr.new]p15: // A new-expression that creates an object of type T initializes that // object as follows: Index: cfe/trunk/test/SemaObjC/arc-repeated-weak.mm =================================================================== --- cfe/trunk/test/SemaObjC/arc-repeated-weak.mm +++ cfe/trunk/test/SemaObjC/arc-repeated-weak.mm @@ -1,5 +1,5 @@ -// RUN: %clang_cc1 -fsyntax-only -fobjc-runtime-has-weak -fobjc-arc -fblocks -Wno-objc-root-class -std=c++11 -Warc-repeated-use-of-weak -verify %s -// RUN: %clang_cc1 -fsyntax-only -fobjc-runtime-has-weak -fobjc-weak -fblocks -Wno-objc-root-class -std=c++11 -Warc-repeated-use-of-weak -verify %s +// RUN: %clang_cc1 -fsyntax-only -fobjc-runtime-has-weak -fobjc-arc -fblocks -Wno-objc-root-class -std=c++14 -Warc-repeated-use-of-weak -verify %s +// RUN: %clang_cc1 -fsyntax-only -fobjc-runtime-has-weak -fobjc-weak -fblocks -Wno-objc-root-class -std=c++14 -Warc-repeated-use-of-weak -verify %s @interface Test { @public @@ -467,6 +467,18 @@ __typeof__(NSBundle2.foo2.weakProp) t5; } +void testAuto() { + auto __weak wp = NSBundle2.foo2.weakProp; +} + +void testLambdaCaptureInit() { + [capture(NSBundle2.foo2.weakProp)] {} (); +} + +void testAutoNew() { + auto p = new auto(NSBundle2.foo2.weakProp); +} + // This used to crash in the constructor of WeakObjectProfileTy when a // DeclRefExpr was passed that didn't reference a VarDecl.