[CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'
ClosedPublic
Actions

Authored by ahatanak on May 29 2019, 9:36 PM.

Details

Reviewers

rjmccall
pete
erik.pilkington

Commits

rL362521: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to
rG48566aaab461: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to…
rC362521: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to

Summary

In a class method, 'self' points to the class object, so it should be safe to pass it to objc_alloc. Also, convert '[[self alloc] init]' in a class method to 'objc_alloc_init(self)'.

rdar://problem/50855121

Diff Detail

Repository: rL LLVM

Event Timeline

ahatanak created this revision.May 29 2019, 9:36 PM

Herald added subscribers: dexonsmith, jkorous. · View Herald TranscriptMay 29 2019, 9:36 PM

rjmccall added inline comments.May 29 2019, 9:50 PM

lib/CodeGen/CGObjC.cpp
376 ↗	(On Diff #202113)	I think it's fine to just call this a class message, unless I'm missing a reason to distinguish them in this function.

Just set isClassMessage instead of passing a separate flag to tryGenerateSpecializedMessageSend.

I thinks this looks good, aside from a null concern.

lib/CodeGen/CGObjC.cpp
460 ↗	(On Diff #202821)	I think (?) that CurFuncDecl is nullable, might want to dyn_cast_or_null here.
528 ↗	(On Diff #202821)	(ditto)

This revision is now accepted and ready to land.Jun 3 2019, 5:09 PM

Closed by commit rL362521: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to (authored by ahatanak, committed by ). · Explain WhyJun 4 2019, 9:28 AM

This revision was automatically updated to reflect the committed changes.

ahatanak marked 2 inline comments as done.

Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2019, 9:29 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

			Path	Packages
M			cfe/trunk/lib/CodeGen/CGObjC.cpp (44 lines)
M			cfe/trunk/test/CodeGenObjC/convert-messages-to-runtime-calls.m (28 lines)
M			cfe/trunk/test/CodeGenObjC/objc-alloc-init.m (6 lines)