Index: llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp =================================================================== --- llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp @@ -1857,13 +1857,22 @@ } Instruction *InstCombiner::visitFNeg(UnaryOperator &I) { - if (Value *V = SimplifyFNegInst(I.getOperand(0), I.getFastMathFlags(), + Value *Op = I.getOperand(0); + + if (Value *V = SimplifyFNegInst(Op, I.getFastMathFlags(), SQ.getWithInstruction(&I))) return replaceInstUsesWith(I, V); if (Instruction *X = foldFNegIntoConstant(I)) return X; + Value *X, *Y; + + // If we can ignore the sign of zeros: -(X - Y) --> (Y - X) + if (I.hasNoSignedZeros() && + match(Op, m_OneUse(m_FSub(m_Value(X), m_Value(Y))))) + return BinaryOperator::CreateFSubFMF(Y, X, &I); + return nullptr; } Index: llvm/trunk/test/Transforms/InstCombine/fsub.ll =================================================================== --- llvm/trunk/test/Transforms/InstCombine/fsub.ll +++ llvm/trunk/test/Transforms/InstCombine/fsub.ll @@ -38,11 +38,9 @@ ret float %t2 } -; FIXME: This combine isn't working. define float @unary_neg_sub_nsz(float %x, float %y) { ; CHECK-LABEL: @unary_neg_sub_nsz( -; CHECK-NEXT: [[T1:%.*]] = fsub float [[X:%.*]], [[Y:%.*]] -; CHECK-NEXT: [[T2:%.*]] = fneg nsz float [[T1]] +; CHECK-NEXT: [[T2:%.*]] = fsub nsz float [[Y:%.*]], [[X:%.*]] ; CHECK-NEXT: ret float [[T2]] ; %t1 = fsub float %x, %y