Index: lib/Target/AMDGPU/AMDGPU.td =================================================================== --- lib/Target/AMDGPU/AMDGPU.td +++ lib/Target/AMDGPU/AMDGPU.td @@ -376,6 +376,12 @@ "Enable SI Machine Scheduler" >; +def FeatureDisableFormClauses : SubtargetFeature<"disable-form-clauses", + "DisableFormClauses", + "true", + "Disable clause formation when XNACK enabled" +>; + def FeatureEnableDS128 : SubtargetFeature<"enable-ds128", "EnableDS128", "true", Index: lib/Target/AMDGPU/AMDGPUSubtarget.h =================================================================== --- lib/Target/AMDGPU/AMDGPUSubtarget.h +++ lib/Target/AMDGPU/AMDGPUSubtarget.h @@ -300,6 +300,7 @@ bool EnableLoadStoreOpt; bool EnableUnsafeDSOffsetFolding; bool EnableSIScheduler; + bool DisableFormClauses; bool EnableDS128; bool EnablePRTStrictNull; bool DumpCode; @@ -784,6 +785,10 @@ return EnableSIScheduler; } + bool disableFormClauses() const { + return DisableFormClauses; + } + bool loadStoreOptEnabled() const { return EnableLoadStoreOpt; } Index: lib/Target/AMDGPU/AMDGPUSubtarget.cpp =================================================================== --- lib/Target/AMDGPU/AMDGPUSubtarget.cpp +++ lib/Target/AMDGPU/AMDGPUSubtarget.cpp @@ -178,6 +178,7 @@ EnableLoadStoreOpt(false), EnableUnsafeDSOffsetFolding(false), EnableSIScheduler(false), + DisableFormClauses(false), EnableDS128(false), EnablePRTStrictNull(false), DumpCode(false), Index: lib/Target/AMDGPU/SIFormMemoryClauses.cpp =================================================================== --- lib/Target/AMDGPU/SIFormMemoryClauses.cpp +++ lib/Target/AMDGPU/SIFormMemoryClauses.cpp @@ -306,7 +306,7 @@ return false; ST = &MF.getSubtarget(); - if (!ST->isXNACKEnabled()) + if (!ST->isXNACKEnabled() || ST->disableFormClauses()) return false; const SIInstrInfo *TII = ST->getInstrInfo(); Index: test/CodeGen/AMDGPU/disable_form_clauses.ll =================================================================== --- /dev/null +++ test/CodeGen/AMDGPU/disable_form_clauses.ll @@ -0,0 +1,65 @@ +; RUN: llc -march=amdgcn -mcpu=gfx902 -verify-machineinstrs -amdgpu-enable-global-sgpr-addr -stop-after=si-form-memory-clauses < %s | FileCheck -check-prefix=GCN %s + +; GCN-LABEL: {{^}}name:{{[ ]*}}vector_clause +; GCN: BUNDLE +; GCN-NEXT: LOAD_DWORDX2 +; GCN-NEXT: LOAD_DWORDX2 +; GCN-NEXT: {{^ *[}]}} +define amdgpu_kernel void @vector_clause(<4 x i32> addrspace(1)* noalias nocapture readonly %arg, <4 x i32> addrspace(1)* noalias nocapture %arg1) { +bb: + %tmp = tail call i32 @llvm.amdgcn.workitem.id.x() + %tmp2 = zext i32 %tmp to i64 + %tmp3 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg, i64 %tmp2 + %tmp4 = load <4 x i32>, <4 x i32> addrspace(1)* %tmp3, align 16 + %tmp5 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg1, i64 %tmp2 + %tmp6 = add nuw nsw i64 %tmp2, 1 + %tmp7 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg, i64 %tmp6 + %tmp8 = load <4 x i32>, <4 x i32> addrspace(1)* %tmp7, align 16 + %tmp9 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg1, i64 %tmp6 + %tmp10 = add nuw nsw i64 %tmp2, 2 + %tmp11 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg, i64 %tmp10 + %tmp12 = load <4 x i32>, <4 x i32> addrspace(1)* %tmp11, align 16 + %tmp13 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg1, i64 %tmp10 + %tmp14 = add nuw nsw i64 %tmp2, 3 + %tmp15 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg, i64 %tmp14 + %tmp16 = load <4 x i32>, <4 x i32> addrspace(1)* %tmp15, align 16 + %tmp17 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg1, i64 %tmp14 + store <4 x i32> %tmp4, <4 x i32> addrspace(1)* %tmp5, align 16 + store <4 x i32> %tmp8, <4 x i32> addrspace(1)* %tmp9, align 16 + store <4 x i32> %tmp12, <4 x i32> addrspace(1)* %tmp13, align 16 + store <4 x i32> %tmp16, <4 x i32> addrspace(1)* %tmp17, align 16 + ret void +} + +; GCN-LABEL: {{^}}name:{{[ ]*}}no_vector_clause +; GCN-NOT: BUNDLE +define amdgpu_kernel void @no_vector_clause(<4 x i32> addrspace(1)* noalias nocapture readonly %arg, <4 x i32> addrspace(1)* noalias nocapture %arg1) #0 { +bb: + %tmp = tail call i32 @llvm.amdgcn.workitem.id.x() + %tmp2 = zext i32 %tmp to i64 + %tmp3 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg, i64 %tmp2 + %tmp4 = load <4 x i32>, <4 x i32> addrspace(1)* %tmp3, align 16 + %tmp5 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg1, i64 %tmp2 + %tmp6 = add nuw nsw i64 %tmp2, 1 + %tmp7 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg, i64 %tmp6 + %tmp8 = load <4 x i32>, <4 x i32> addrspace(1)* %tmp7, align 16 + %tmp9 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg1, i64 %tmp6 + %tmp10 = add nuw nsw i64 %tmp2, 2 + %tmp11 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg, i64 %tmp10 + %tmp12 = load <4 x i32>, <4 x i32> addrspace(1)* %tmp11, align 16 + %tmp13 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg1, i64 %tmp10 + %tmp14 = add nuw nsw i64 %tmp2, 3 + %tmp15 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg, i64 %tmp14 + %tmp16 = load <4 x i32>, <4 x i32> addrspace(1)* %tmp15, align 16 + %tmp17 = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(1)* %arg1, i64 %tmp14 + store <4 x i32> %tmp4, <4 x i32> addrspace(1)* %tmp5, align 16 + store <4 x i32> %tmp8, <4 x i32> addrspace(1)* %tmp9, align 16 + store <4 x i32> %tmp12, <4 x i32> addrspace(1)* %tmp13, align 16 + store <4 x i32> %tmp16, <4 x i32> addrspace(1)* %tmp17, align 16 + ret void +} + +declare i32 @llvm.amdgcn.workitem.id.x() + +attributes #0 = { "target-features"="+disable-form-clauses" } +