Page MenuHomePhabricator

lld/mach-o should set MH_NO_REEXPORTED_DYLIBS if there are no REEXPORT_DYLIB libraries
Needs ReviewPublic

Authored by carlokok on May 28 2019, 10:30 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Currently it doesn't ever set that, this patch sets it unless there are reexported libraries. When this happens ld64 doesn't like linking to it, failing with the error that MH_NO_REEXPORTED_DYLIBS should have been set.

(Thanks to @LemonBoy for helping me with this patch)

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

carlokok created this revision.May 28 2019, 10:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2019, 10:30 PM
carlokok updated this revision to Diff 201825.May 28 2019, 10:32 PM

Remove unused var