Index: llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.h =================================================================== --- llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.h +++ llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.h @@ -42,11 +42,6 @@ unsigned SrcReg, DenseMap &VRBaseMap); - /// getDstOfCopyToRegUse - If the only use of the specified result number of - /// node is a CopyToReg, return its destination register. Return 0 otherwise. - unsigned getDstOfOnlyCopyToRegUse(SDNode *Node, - unsigned ResNo) const; - void CreateVirtualRegisters(SDNode *Node, MachineInstrBuilder &MIB, const MCInstrDesc &II, Index: llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.cpp =================================================================== --- llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.cpp +++ llvm/trunk/lib/CodeGen/SelectionDAG/InstrEmitter.cpp @@ -186,24 +186,6 @@ assert(isNew && "Node emitted out of order - early"); } -/// getDstOfCopyToRegUse - If the only use of the specified result number of -/// node is a CopyToReg, return its destination register. Return 0 otherwise. -unsigned InstrEmitter::getDstOfOnlyCopyToRegUse(SDNode *Node, - unsigned ResNo) const { - if (!Node->hasOneUse()) - return 0; - - SDNode *User = *Node->use_begin(); - if (User->getOpcode() == ISD::CopyToReg && - User->getOperand(2).getNode() == Node && - User->getOperand(2).getResNo() == ResNo) { - unsigned Reg = cast(User->getOperand(1))->getReg(); - if (TargetRegisterInfo::isVirtualRegister(Reg)) - return Reg; - } - return 0; -} - void InstrEmitter::CreateVirtualRegisters(SDNode *Node, MachineInstrBuilder &MIB, const MCInstrDesc &II, @@ -286,14 +268,11 @@ if (Op.isMachineOpcode() && Op.getMachineOpcode() == TargetOpcode::IMPLICIT_DEF) { // Add an IMPLICIT_DEF instruction before every use. - unsigned VReg = getDstOfOnlyCopyToRegUse(Op.getNode(), Op.getResNo()); // IMPLICIT_DEF can produce any type of result so its MCInstrDesc // does not include operand register class info. - if (!VReg) { - const TargetRegisterClass *RC = TLI->getRegClassFor( - Op.getSimpleValueType(), Op.getNode()->isDivergent()); - VReg = MRI->createVirtualRegister(RC); - } + const TargetRegisterClass *RC = TLI->getRegClassFor( + Op.getSimpleValueType(), Op.getNode()->isDivergent()); + unsigned VReg = MRI->createVirtualRegister(RC); BuildMI(*MBB, InsertPos, Op.getDebugLoc(), TII->get(TargetOpcode::IMPLICIT_DEF), VReg); return VReg; @@ -1011,14 +990,23 @@ case ISD::TokenFactor: // fall thru break; case ISD::CopyToReg: { - unsigned SrcReg; + unsigned DestReg = cast(Node->getOperand(1))->getReg(); SDValue SrcVal = Node->getOperand(2); + if (TargetRegisterInfo::isVirtualRegister(DestReg) && + SrcVal.isMachineOpcode() && + SrcVal.getMachineOpcode() == TargetOpcode::IMPLICIT_DEF) { + // Instead building a COPY to that vreg destination, build an + // IMPLICIT_DEF instruction instead. + BuildMI(*MBB, InsertPos, Node->getDebugLoc(), + TII->get(TargetOpcode::IMPLICIT_DEF), DestReg); + break; + } + unsigned SrcReg; if (RegisterSDNode *R = dyn_cast(SrcVal)) SrcReg = R->getReg(); else SrcReg = getVR(SrcVal, VRBaseMap); - unsigned DestReg = cast(Node->getOperand(1))->getReg(); if (SrcReg == DestReg) // Coalesced away the copy? Ignore. break; Index: llvm/trunk/test/CodeGen/AMDGPU/i1-copy-phi.ll =================================================================== --- llvm/trunk/test/CodeGen/AMDGPU/i1-copy-phi.ll +++ llvm/trunk/test/CodeGen/AMDGPU/i1-copy-phi.ll @@ -37,3 +37,22 @@ declare i32 @llvm.amdgcn.workitem.id.x() #0 attributes #0 = { nounwind readnone } + +; Make sure this won't crash. +; SI-LABEL: {{^}}vcopy_i1_undef +; SI: v_cndmask_b32_e64 +; SI: v_cndmask_b32_e64 +define <2 x float> @vcopy_i1_undef(<2 x float> addrspace(1)* %p) { +entry: + br i1 undef, label %exit, label %false + +false: + %x = load <2 x float>, <2 x float> addrspace(1)* %p + %cmp = fcmp one <2 x float> %x, zeroinitializer + br label %exit + +exit: + %c = phi <2 x i1> [ undef, %entry ], [ %cmp, %false ] + %ret = select <2 x i1> %c, <2 x float> , <2 x float> + ret <2 x float> %ret +} Index: llvm/trunk/test/CodeGen/AMDGPU/implicit-def-muse.ll =================================================================== --- llvm/trunk/test/CodeGen/AMDGPU/implicit-def-muse.ll +++ llvm/trunk/test/CodeGen/AMDGPU/implicit-def-muse.ll @@ -0,0 +1,22 @@ +; RUN: llc -march=amdgcn -stop-after=amdgpu-isel -verify-machineinstrs -o - %s | FileCheck %s + +; CHECK-LABEL: vcopy_i1_undef +; CHECK: IMPLICIT_DEF +; CHECK-NOT: COPY +; CHECK: IMPLICIT_DEF +; CHECK-NOT: COPY +; CHECK: .false: +define <2 x float> @vcopy_i1_undef(<2 x float> addrspace(1)* %p) { +entry: + br i1 undef, label %exit, label %false + +false: + %x = load <2 x float>, <2 x float> addrspace(1)* %p + %cmp = fcmp one <2 x float> %x, zeroinitializer + br label %exit + +exit: + %c = phi <2 x i1> [ undef, %entry ], [ %cmp, %false ] + %ret = select <2 x i1> %c, <2 x float> , <2 x float> + ret <2 x float> %ret +}