This is an archive of the discontinued LLVM Phabricator instance.

CMake: allow using LLVM_EXTERNAL_PROJECTS with LLVM_ENABLE_PROJECTS
ClosedPublic

Authored by hans on May 23 2019, 12:40 AM.

Details

Summary

The current code iterates over the combination of LLVM_EXTERNAL_PROJECTS and LLVM_ENABLE_PROJECTS, but then disables projects that are only in the former. If a project is in LLVM_EXTERNAL_PROJECTS, it should be enabled.

See also llvm-commits thread on r354060.

Diff Detail

Repository
rL LLVM

Event Timeline

hans created this revision.May 23 2019, 12:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2019, 12:40 AM
Herald added a subscriber: mgorny. · View Herald Transcript
smeenai accepted this revision.May 23 2019, 9:15 AM

LGTM

This revision is now accepted and ready to land.May 23 2019, 9:15 AM
beanz accepted this revision.May 23 2019, 10:37 AM

Makes sense to me.

This revision was automatically updated to reflect the committed changes.