Page MenuHomePhabricator

[ProcessWindows] Improve support for launching processes.

Authored by zturner on Nov 11 2014, 4:04 PM.



Because I structured the core debug loop differently from your original patch, I'm mostly re-writing your patch rather than doing a straight merge, although I'm heavily referring to your patch in the process. I do plan to credit your original patch when I commit though. Would appreciate some feedback since you've already gone through all this learning before. I'm doing this in small pieces rather than all at once, so there's still many pieces of your patch which are not here yet.

This particular piece sends notifications for module load / unload to the process plugin, and also fixes some issues managing the state more accurately during the loading sequence.

Not yet implemented: any kind of thread management, dynamic loader plugin, attaching to processes, breakpoint management other than getting the low level exception, or stepping.

Diff Detail


Event Timeline

zturner updated this revision to Diff 16067.Nov 11 2014, 4:04 PM
zturner retitled this revision from to [ProcessWindows] Improve support for launching processes..
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a reviewer: xen2.
zturner added a subscriber: Unknown Object (MLST).
zturner updated this revision to Diff 16107.Nov 12 2014, 11:22 AM

Fixed a few issues. I'm going to go ahead and submit this patch since I'm not sure how active you area in checking this or if your time permits you to do an actual review. Also, it doesn't affect anyone else and this is all new functionality.

That being said, if you do find some time, would love some feedback.

zturner closed this revision.Nov 12 2014, 11:32 AM
zturner updated this revision to Diff 16109.

Closed by commit rL221807 (authored by @zturner).

xen2 edited edge metadata.Nov 13 2014, 2:37 AM

Looks good to me!