Page MenuHomePhabricator

Enable standard so versioning for libLLVM.
ClosedPublic

Authored by beanz on Nov 6 2014, 3:14 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 15898.Nov 6 2014, 3:14 PM
beanz retitled this revision from to Enable standard so versioning for libLLVM..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added a reviewer: chapuni.
beanz added a subscriber: Unknown Object (MLST).
chapuni edited edge metadata.Nov 6 2014, 5:30 PM

Looks good. Although I could accept this, excuse me to sit here to listen in more opinions.

I wish this logic into llvm_add_library(). Versioning may be general among shared libs. I will do in future.

FYI, autoconf's --enable-shared emits the library like libLLVM-3.6.0svn.so.

In llvm-shlib/Makefile;

LIBRARYNAME = LLVM-$(LLVM_VERSION_MAJOR).$(LLVM_VERSION_MINOR)$(LLVM_VERSION_SUFFIX)
LIBRARYALIASNAME = LLVM-$(LLVMVersion)

In Makefile.config;

LLVMVersion       := 3.6.0svn
LLVM_VERSION_MAJOR := 3
LLVM_VERSION_MINOR := 6
LLVM_VERSION_PATCH := 0
LLVM_VERSION_SUFFIX := svn

To which way shall we follow?

beanz added a comment.Nov 6 2014, 5:38 PM

I think you are right, and that is a better way to handle this problem. I'll work on updated patches. I'll also add the LLVM_VERSION_SUFFIX to match the autotools implementation so that we have parity.

beanz updated this revision to Diff 15902.Nov 6 2014, 5:42 PM
beanz edited edge metadata.

Moved the so versioning support into llvm_add_library so that it applies to all shared libraries, not just libLLVM.

pete accepted this revision.Feb 18 2015, 9:53 AM
pete added a reviewer: pete.
pete added a subscriber: pete.

Updated patch LGTM.

This revision is now accepted and ready to land.Feb 18 2015, 9:53 AM
This revision was automatically updated to reflect the committed changes.