diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp --- a/clang/lib/CodeGen/CGCall.cpp +++ b/clang/lib/CodeGen/CGCall.cpp @@ -4370,7 +4370,6 @@ } // Add metadata for calls to MSAllocator functions - // FIXME: Get the type that the return value is cast to. if (getDebugInfo() && TargetDecl && TargetDecl->hasAttr()) getDebugInfo()->addHeapAllocSiteMetadata(CI, RetTy, Loc); diff --git a/clang/lib/CodeGen/CGExprScalar.cpp b/clang/lib/CodeGen/CGExprScalar.cpp --- a/clang/lib/CodeGen/CGExprScalar.cpp +++ b/clang/lib/CodeGen/CGExprScalar.cpp @@ -569,6 +569,7 @@ } Value *VisitExplicitCastExpr(ExplicitCastExpr *E) { CGF.CGM.EmitExplicitCastExprType(E, &CGF); + return VisitCastExpr(E); } Value *VisitCastExpr(CastExpr *E); @@ -2063,6 +2064,12 @@ } } + // Update heapallocsite metadata when there is an explicit cast. + if (llvm::CallInst *CI = dyn_cast(Src)) + if (CI->getMetadata("heapallocsite") && dyn_cast(CE)) + CGF.getDebugInfo()-> + addHeapAllocSiteMetadata(CI, CE->getType(), CE->getExprLoc()); + return Builder.CreateBitCast(Src, DstTy); } case CK_AddressSpaceConversion: { diff --git a/clang/test/CodeGen/debug-info-codeview-heapallocsite.c b/clang/test/CodeGen/debug-info-codeview-heapallocsite.c --- a/clang/test/CodeGen/debug-info-codeview-heapallocsite.c +++ b/clang/test/CodeGen/debug-info-codeview-heapallocsite.c @@ -5,23 +5,16 @@ }; __declspec(allocator) void *alloc_void(); -__declspec(allocator) struct Foo *alloc_foo(); -void call_alloc_void() { - struct Foo *p = (struct Foo*)alloc_void(); +void call_alloc() { + struct Foo *p = alloc_void(); + struct Foo *q = (struct Foo*)alloc_void(); } -void call_alloc_foo() { - struct Foo *p = alloc_foo(); -} - -// CHECK-LABEL: define {{.*}}void @call_alloc_void +// CHECK-LABEL: define {{.*}}void @call_alloc // CHECK: call i8* {{.*}}@alloc_void{{.*}} !heapallocsite [[DBG1:!.*]] - -// CHECK-LABEL: define {{.*}}void @call_alloc_foo -// CHECK: call %struct.Foo* {{.*}}@alloc_foo{{.*}} !heapallocsite [[DBG2:!.*]] +// CHECK: call i8* {{.*}}@alloc_void{{.*}} !heapallocsite [[DBG2:!.*]] // CHECK: [[DBG1]] = !{} // CHECK: [[DBG2]] = distinct !DICompositeType(tag: DW_TAG_structure_type, // CHECK-SAME: name: "Foo" - diff --git a/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp b/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp --- a/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp +++ b/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp @@ -1090,7 +1090,7 @@ OS.AddComment("Call instruction length"); OS.emitAbsoluteSymbolDiff(EndLabel, BeginLabel, 2); OS.AddComment("Type index"); - OS.EmitIntValue(getCompleteTypeIndex(DITy).getIndex(), 4); + OS.EmitIntValue(getTypeIndex(DITy).getIndex(), 4); endSymbolRecord(HeapAllocEnd); }