Page MenuHomePhabricator

Fix compilation of DataFormatters/StringPrinter.cpp with GCC.
AbandonedPublic

Authored by sivachandra on Nov 4 2014, 12:02 PM.

Details

Reviewers
clayborg
Summary

GCC apparently does not like template specializations with namespace
qualifiers such as this:

template <>
bool
namespace1::namespace2::funcName<...>()
{

...

}

GCC ToT also errors out with such namespace qualification of explicit
template specializations.

I have removed such a usage and put in the old style way of doing the
same:

namespace namespace1
{

namespace namespace2
{
  template <>
  bool
  funcName<...>()
  {
    ...
  }
} // namesapce namespace2

} // namespace namesapce3

Diff Detail

Event Timeline

sivachandra retitled this revision from to Fix compilation of DataFormatters/StringPrinter.cpp with GCC..
sivachandra updated this object.
sivachandra edited the test plan for this revision. (Show Details)
sivachandra added a reviewer: epertoso.
sivachandra added a subscriber: Unknown Object (MLST).
sivachandra added a reviewer: clayborg.

I got the wrong "enrico" in my first attempt.

sbest added a subscriber: sbest.Nov 4 2014, 2:42 PM

Builds and runs fine on OSX/clang as well as Linux/gcc. I will go ahead
and commit.

granata.enrico resigned from this revision.Oct 15 2015, 1:32 PM
granata.enrico removed a reviewer: granata.enrico.
clayborg edited edge metadata.Oct 15 2015, 2:01 PM

If you still care about this, please resubmit against current sources.

sivachandra abandoned this revision.Oct 15 2015, 2:04 PM

This was from the time when I did not have commit access. sbest committed this for me separately.