Page MenuHomePhabricator

[ARM] Remove references to redundant cortex-a9-mp CPU
Needs ReviewPublic

Authored by chatur01 on Nov 4 2014, 9:10 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This CPU definition is redundant and was recently removed from LLVM (see http://reviews.llvm.org/D6057)

This patch removes the remaining references to it from Clang.

Diff Detail

Event Timeline

chatur01 retitled this revision from to [ARM] Remove references to redundant cortex-a9-mp CPU.
chatur01 updated this object.
chatur01 edited the test plan for this revision. (Show Details)
chatur01 added a subscriber: Unknown Object (MLST).

I can't remember now, does that mean that "-mcpu=cortex-a9-mp" will work and mean "arm7tdmi" or will it fail with "unknown CPU"? I'm actually surprised that we had no tests for it. :)

If it fails, LGTM. If not, the odd folks using it may have a nasty selection of compile/link/run-time errors.

cheers,
--renato

In D6118#4, @rengolin wrote:

I can't remember now, does that mean that "-mcpu=cortex-a9-mp" will work and mean "arm7tdmi" or will it fail with "unknown CPU"?

It does fail,

$ clang -target arm-none-eabi -mcpu=cortex-a9-mp test.ll 
error: unknown target CPU 'cortex-a9-mp'

I'm actually surprised that we had no tests for it. :)

So was I! :)

Thank you for reviewing,
Charlie.

Hi Renato,

Thanks again for looking. Committed as r221458.

Charlie.