This is an archive of the discontinued LLVM Phabricator instance.

Differential D60726

Fixed -Wconversion-null warning in GCC.
ClosedPublic

Authored by dendibakh on Apr 15 2019, 10:38 AM.

Details

Reviewers
reuk
Commits
rG407dd4d1693d: [clang-format] Fix -Wconversion-null warning in GCC
rC358441: [clang-format] Fix -Wconversion-null warning in GCC
rL358441: [clang-format] Fix -Wconversion-null warning in GCC
Summary

GCC -Wconversion-null warning appeared after 9a63380260860b657b72f07c4f0e61e382ab934a.
There was a similar problem already in the past:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20131230/096230.html

Diff Detail

Repository
rL LLVM

Event Timeline

dendibakh created this revision.Apr 15 2019, 10:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2019, 10:38 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
reuk accepted this revision.Apr 15 2019, 11:51 AM

LGTM

This revision is now accepted and ready to land.Apr 15 2019, 11:51 AM
dendibakh added a comment.Apr 15 2019, 11:54 AM

@reuk , can you please commit this patch on my behalf?

Closed by commit rL358441: [clang-format] Fix -Wconversion-null warning in GCC (authored by reuk). · Explain WhyApr 15 2019, 1:11 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2019, 1:11 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
unittests/
Format/
7 lines

Diff 195240

cfe/trunk/unittests/Format/FormatTest.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 11,387 Lines • ▼ Show 20 LinesTEST_F(FormatTest, ParsesConfigurationBools) {
CHECK_PARSE_BOOL(SpacesInParentheses); CHECK_PARSE_BOOL(SpacesInParentheses);
CHECK_PARSE_BOOL(SpacesInSquareBrackets); CHECK_PARSE_BOOL(SpacesInSquareBrackets);
CHECK_PARSE_BOOL(SpacesInAngles); CHECK_PARSE_BOOL(SpacesInAngles);
CHECK_PARSE_BOOL(SpaceInEmptyParentheses); CHECK_PARSE_BOOL(SpaceInEmptyParentheses);
CHECK_PARSE_BOOL(SpacesInContainerLiterals); CHECK_PARSE_BOOL(SpacesInContainerLiterals);
CHECK_PARSE_BOOL(SpacesInCStyleCastParentheses); CHECK_PARSE_BOOL(SpacesInCStyleCastParentheses);
CHECK_PARSE_BOOL(SpaceAfterCStyleCast); CHECK_PARSE_BOOL(SpaceAfterCStyleCast);
CHECK_PARSE_BOOL(SpaceAfterTemplateKeyword); CHECK_PARSE_BOOL(SpaceAfterTemplateKeyword);
CHECK_PARSE_BOOL(SpaceAfterLogicalNot);
CHECK_PARSE_BOOL(SpaceBeforeAssignmentOperators); CHECK_PARSE_BOOL(SpaceBeforeAssignmentOperators);
CHECK_PARSE_BOOL(SpaceBeforeCpp11BracedList); CHECK_PARSE_BOOL(SpaceBeforeCpp11BracedList);
CHECK_PARSE_BOOL(SpaceBeforeCtorInitializerColon); CHECK_PARSE_BOOL(SpaceBeforeCtorInitializerColon);
CHECK_PARSE_BOOL(SpaceBeforeInheritanceColon); CHECK_PARSE_BOOL(SpaceBeforeInheritanceColon);
CHECK_PARSE_BOOL(SpaceBeforeRangeBasedForLoopColon); CHECK_PARSE_BOOL(SpaceBeforeRangeBasedForLoopColon);
CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterCaseLabel); CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterCaseLabel);
CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterClass); CHECK_PARSE_NESTED_BOOL(BraceWrapping, AfterClass);
▲ Show 20 Lines • Show All 157 Lines • ▼ Show 20 LinesTEST_F(FormatTest, ParsesConfiguration) {
CHECK_PARSE("SpaceBeforeParens: NonEmptyParentheses", SpaceBeforeParens, CHECK_PARSE("SpaceBeforeParens: NonEmptyParentheses", SpaceBeforeParens,
FormatStyle::SBPO_NonEmptyParentheses); FormatStyle::SBPO_NonEmptyParentheses);
// For backward compatibility: // For backward compatibility:
CHECK_PARSE("SpaceAfterControlStatementKeyword: false", SpaceBeforeParens, CHECK_PARSE("SpaceAfterControlStatementKeyword: false", SpaceBeforeParens,
FormatStyle::SBPO_Never); FormatStyle::SBPO_Never);
CHECK_PARSE("SpaceAfterControlStatementKeyword: true", SpaceBeforeParens, CHECK_PARSE("SpaceAfterControlStatementKeyword: true", SpaceBeforeParens,
FormatStyle::SBPO_ControlStatements); FormatStyle::SBPO_ControlStatements);
Style.SpaceAfterLogicalNot = false;
CHECK_PARSE("SpaceAfterLogicalNot: true", SpaceAfterLogicalNot,
true);
CHECK_PARSE("SpaceAfterLogicalNot: false", SpaceAfterLogicalNot,
false);
Style.ColumnLimit = 123; Style.ColumnLimit = 123;
FormatStyle BaseStyle = getLLVMStyle(); FormatStyle BaseStyle = getLLVMStyle();
CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit); CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit);
CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u); CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u);
Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup;
CHECK_PARSE("BreakBeforeBraces: Attach", BreakBeforeBraces, CHECK_PARSE("BreakBeforeBraces: Attach", BreakBeforeBraces,
FormatStyle::BS_Attach); FormatStyle::BS_Attach);
▲ Show 20 Lines • Show All 1,930 Lines • Show Last 20 Lines