[HIP] Use -mlink-builtin-bitcode to link device library
ClosedPublic
Actions

Authored by yaxunl on Apr 10 2019, 8:04 AM.

Details

Reviewers

tra
ashi1

Commits

rG7bd8c37b1773: [HIP] Use -mlink-builtin-bitcode to link device library
rC358290: [HIP] Use -mlink-builtin-bitcode to link device library
rL358290: [HIP] Use -mlink-builtin-bitcode to link device library

Summary

Use -mlink-builtin-bitcode instead of llvm-link to link
device library so that device library bitcode and user
device code can be compiled in a consistent way.

This is the same approach used by CUDA and OpenMP.

Diff Detail

Repository: rL LLVM

Event Timeline

yaxunl created this revision.Apr 10 2019, 8:04 AM

Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 10 2019, 8:04 AM

LGTM

This revision is now accepted and ready to land.Apr 10 2019, 10:54 AM

tra accepted this revision.Apr 10 2019, 12:01 PM

Closed by commit rL358290: [HIP] Use -mlink-builtin-bitcode to link device library (authored by yaxunl, committed by ). · Explain WhyApr 12 2019, 9:21 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2019, 9:22 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents
Changeset List

			Path	Packages
M			cfe/trunk/lib/Driver/ToolChains/HIP.cpp (81 lines)
M			cfe/trunk/test/Driver/hip-device-libs.hip (13 lines)
M			cfe/trunk/test/Driver/hip-toolchain-no-rdc.hip (8 lines)
M			cfe/trunk/test/Driver/hip-toolchain-rdc.hip (12 lines)