Page MenuHomePhabricator

Add dropped ManualDWARFIndex assert()
ClosedPublic

Authored by jankratochvil on Apr 4 2019, 12:50 AM.

Details

Summary

D47253 dropped this assertion. So either add it back by this patch or otherwise I will remove currently unused SymbolFileDWARF::GetBaseCompileUnit.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

jankratochvil created this revision.Apr 4 2019, 12:50 AM
labath added a comment.Apr 4 2019, 1:59 AM

I don't exactly remember my thought processes there, but I guess I have dropped that assert during the refactor because it was obvious to me.

Now that you mention it, I don't have any particular opinion on what we should do. If it makes your job any easier, then go ahead and remove GetBaseCompileUnit. Otherwise, I suppose it might be good to re-add the assert.

Maybe I will have to update GetBaseCompileUnit, maybe not. But as I find the assert useful (for -fdebug-types-section -gsplit-dwarf) going to add back the assertion. Thanks for the reply.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 4 2019, 2:22 AM
This revision was automatically updated to reflect the committed changes.