This is an archive of the discontinued LLVM Phabricator instance.

Clang cmake fix for lib naming http://llvm.org/bugs/show_bug.cgi?id=13909
AbandonedPublic

Authored by martell on Mar 30 2013, 7:52 PM.

Details

Reviewers
yaron.keren
rnk
Summary

Mingw and mingw64 builds compile to liblibclang.dll

and this diff will change that back to libclang.dll

mingw is like linux in that it prepends the lib word :)

http://llvm.org/bugs/show_bug.cgi?id=13909

This patch is over 2 years old :D
but it was never merged
adding reviewers to see if we can squash this bug

Diff Detail

Event Timeline

Hi chandler,

This is my first ever diff patch pull request.
I hope I have done it correctly.

Looking forward to your input :)

chandlerc resigned from this revision.Mar 29 2015, 11:23 AM
chandlerc removed a reviewer: chandlerc.
martell updated this object.
yaron.keren edited edge metadata.Jul 9 2015, 12:01 PM

On my mingw 4.9.1 builds (without this patch) I get "libclang.dll" and not "liblibclang.dll".
Do you still get "liblibclang.dll" with current SVN (without this patch) ?

On my mingw 4.9.1 builds (without this patch) I get "libclang.dll" and not "liblibclang.dll".
Do you still get "liblibclang.dll" with current SVN (without this patch) ?

Still not quite sure how to reply to a comment. I'm a phabricator noob :)
I only noticed this patch when I logged in
Ahh yes I just checked you are correct it is now fixed on svn

not sure when but this should probably be closed
http://llvm.org/bugs/show_bug.cgi?id=13909

martell abandoned this revision.Jul 9 2015, 12:44 PM