This is an archive of the discontinued LLVM Phabricator instance.

Differential D59610

[AMDGPU] Fix dependency on `BinaryFormat`
ClosedPublic

Authored by hliao on Mar 20 2019, 1:40 PM.

Details

Reviewers
rampitec
arsenm
tpr
Commits
rL356617: [AMDGPU] Fix dependency on `BinaryFormat`
rGbbcb95a64e18: [AMDGPU] Fix dependency on `BinaryFormat`
Summary
  • The linking is broken when this library is built as shared one.

Diff Detail

Event Timeline

hliao created this revision.Mar 20 2019, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2019, 1:40 PM
Herald added subscribers: llvm-commits, hiraditya, t-tye and 8 others. · View Herald Transcript
Harbormaster completed remote builds in B29411: Diff 191571.Mar 20 2019, 1:40 PM
hliao added reviewers: rampitec, arsenm.Mar 20 2019, 1:41 PM
arsenm added a reviewer: tpr.Mar 20 2019, 1:47 PM
arsenm accepted this revision.Mar 20 2019, 1:53 PM
This revision is now accepted and ready to land.Mar 20 2019, 1:53 PM
Closed by commit rGbbcb95a64e18: [AMDGPU] Fix dependency on `BinaryFormat` (authored by hliao). · Explain WhyMar 20 2019, 2:24 PM
This revision was automatically updated to reflect the committed changes.
kzhuravl mentioned this in D59614: [AMDGPU] Add missing dependency on BinaryFormat.Mar 20 2019, 2:27 PM

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
Utils/
2 lines

Diff 191583

llvm/lib/Target/AMDGPU/Utils/LLVMBuild.txt

Show All 12 Lines
; http://llvm.org/docs/LLVMBuild.html ; http://llvm.org/docs/LLVMBuild.html
; ;
;===------------------------------------------------------------------------===; ;===------------------------------------------------------------------------===;
[component_0] [component_0]
type = Library type = Library
name = AMDGPUUtils name = AMDGPUUtils
parent = AMDGPU parent = AMDGPU
required_libraries = Core MC Support required_libraries = Core MC BinaryFormat Support
add_to_library_groups = AMDGPU add_to_library_groups = AMDGPU