Page MenuHomePhabricator

[libc++][CMake] Allow merging libc++abi.a into libc++ even on Apple platforms
ClosedPublic

Authored by ldionne on Mar 18 2019, 2:09 PM.

Details

Summary

I can't see a good reason to disallow this, even though it isn't the
standard way we build libc++ for Apple platforms.

Making this work on Apple platforms requires using different flags for
--whole-archive and removing the -D flag when running ar to merge
archives because that flag isn't supported by the ar shipped on Apple
platforms. This shouldn't be an issue since the -D option appears to be
enabled by default in GNU ar.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Mar 18 2019, 2:09 PM

See also D44671.

This patch effectively supersedes D44671.

phosek accepted this revision.Mar 25 2019, 7:53 AM

LGTM, thank you!

This revision is now accepted and ready to land.Mar 25 2019, 7:53 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2019, 7:55 AM