Index: ELF/InputFiles.cpp =================================================================== --- ELF/InputFiles.cpp +++ ELF/InputFiles.cpp @@ -1193,14 +1193,17 @@ unsigned char Endian; std::tie(Size, Endian) = getElfArchType(MB.getBuffer()); - auto Fatal = [&](StringRef Msg) { + auto Fatal = [&](StringRef Msg, bool NotElf = false) { StringRef Filename = MB.getBufferIdentifier(); + StringRef MsgPrefix = NotElf ? ": " : ": corrupted ELF file: "; if (ArchiveName.empty()) - fatal(Filename + ": corrupted ELF file: " + Msg); + fatal(Filename + MsgPrefix + Msg); else - fatal(ArchiveName + "(" + Filename + "): corrupted ELF file: " + Msg); + fatal(ArchiveName + "(" + Filename + ")" + MsgPrefix + Msg); }; + if (!MB.getBuffer().startswith(ElfMagic)) + Fatal("not an ELF file", true); if (Endian != ELFDATA2LSB && Endian != ELFDATA2MSB) Fatal("invalid data encoding"); if (Size != ELFCLASS32 && Size != ELFCLASS64) Index: test/ELF/invalid/invalid-elf.test =================================================================== --- test/ELF/invalid/invalid-elf.test +++ test/ELF/invalid/invalid-elf.test @@ -1,11 +1,18 @@ # REQUIRES: x86 -# RUN: llvm-mc %s -o %t -filetype=obj -triple x86_64-pc-linux +# RUN: rm -rf %t && mkdir -p %t +# RUN: llvm-mc %s -o %t/simple.o -filetype=obj -triple x86_64-pc-linux +# RUN: echo > %t/empty.o +# RUN: llvm-ar cr %t/not-elf.a %t/empty.o -# RUN: not ld.lld %t %p/Inputs/data-encoding.a -o %t2 2>&1 | \ +# RUN: not ld.lld %t/simple.o %t/not-elf.a -o %t2 2>&1 | \ +# RUN: FileCheck --check-prefix=NOT-ELF %s +# NOT-ELF: not-elf.a(empty.o): not an ELF file + +# RUN: not ld.lld %t/simple.o %p/Inputs/data-encoding.a -o %t2 2>&1 | \ # RUN: FileCheck --check-prefix=INVALID-DATA-ENC %s # INVALID-DATA-ENC: data-encoding.a(test.o): corrupted ELF file: invalid data encoding -# RUN: not ld.lld %t %p/Inputs/file-class.a -o %t2 2>&1 | \ +# RUN: not ld.lld %t/simple.o %p/Inputs/file-class.a -o %t2 2>&1 | \ # RUN: FileCheck --check-prefix=INVALID-FILE-CLASS %s # INVALID-FILE-CLASS: file-class.a(test.o): corrupted ELF file: invalid file class